Merge lp:~laney/unity-control-center/appearance-settings-schema-unref into lp:unity-control-center

Proposed by Iain Lane on 2014-07-02
Status: Merged
Approved by: Lars Karlitski on 2014-07-02
Approved revision: 12783
Merged at revision: 12782
Proposed branch: lp:~laney/unity-control-center/appearance-settings-schema-unref
Merge into: lp:unity-control-center
Diff against target: 12 lines (+1/-1)
1 file modified
panels/appearance/cc-appearance-panel.c (+1/-1)
To merge this branch: bzr merge lp:~laney/unity-control-center/appearance-settings-schema-unref
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve on 2014-07-02
PS Jenkins bot (community) continuous-integration Approve on 2014-07-02
Unity Control Center development team 2014-07-02 Pending
Review via email:

Commit message

[appearance] Fix a g_object_unref on a GSettingsSchema to be g_settings_schema_unref

To post a comment you must log in.
James Hunt (jamesodhunt) wrote :

Is it possible to add a DEP-8 test for unity-control-center somehow?

Iain Lane (laney) wrote :

On Wed, Jul 02, 2014 at 10:20:45AM -0000, James Hunt wrote:
> Is it possible to add a DEP-8 test for unity-control-center somehow?

I guess autopilot tests would be ideal. That's a lot of work though.

You could probably write a simple DEP-8 test which tries to launch all
of the panels and checks they don't crash. That would have caught this
problem when the new glib was uploaded.

Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Lars Karlitski (larsu) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/appearance/cc-appearance-panel.c'
2--- panels/appearance/cc-appearance-panel.c 2014-03-17 04:22:52 +0000
3+++ panels/appearance/cc-appearance-panel.c 2014-07-02 10:10:56 +0000
4@@ -1847,7 +1847,7 @@
5 if (schema)
6 {
7 priv->unity_launcher_settings = g_settings_new (UNITY_LAUNCHER_GSETTINGS_SCHEMA);
8- g_object_unref (schema);
9+ g_settings_schema_unref (schema);
10 }
11 schema = g_settings_schema_source_lookup (source, UNITY_GSETTINGS_SCHEMA, TRUE);
12 if (schema)


People subscribed via source and target branches