Merge lp:~laney/unity-control-center/appearance-settings-schema-unref into lp:unity-control-center

[Iain Lane]

[appearance] Fix a g_object_unref on a GSettingsSchema to be g_settings_schema_unref

[James Hunt (jamesodhunt)]

Is it possible to add a DEP-8 test for unity-control-center somehow?

[Iain Lane (laney)]

On Wed, Jul 02, 2014 at 10:20:45AM -0000, James Hunt wrote:
> Is it possible to add a DEP-8 test for unity-control-center somehow?

I guess autopilot tests would be ideal. That's a lot of work though.

You could probably write a simple DEP-8 test which tries to launch all
of the panels and checks they don't crash. That would have caught this
problem when the new glib was uploaded.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:12783
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/102/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/102/rebuild

review: Approve (continuous-integration)

[Lars Karlitski (larsu)]

Thanks!

review: Approve

=== modified file 'panels/appearance/cc-appearance-panel.c'
--- panels/appearance/cc-appearance-panel.c	2014-03-17 04:22:52 +0000
+++ panels/appearance/cc-appearance-panel.c	2014-07-02 10:10:56 +0000
@@ -1847,7 +1847,7 @@
   if (schema)
     {
       priv->unity_launcher_settings = g_settings_new (UNITY_LAUNCHER_GSETTINGS_SCHEMA);
-      g_object_unref (schema);
+      g_settings_schema_unref (schema);
     }
   schema = g_settings_schema_source_lookup (source, UNITY_GSETTINGS_SCHEMA, TRUE);
   if (schema)