Merge lp:~laney/ubuntuone-credentials/multiarch-common into lp:ubuntuone-credentials

Proposed by Iain Lane
Status: Merged
Approved by: dobey
Approved revision: 92
Merge reported by: Robert Bruce Park
Merged at revision: not available
Proposed branch: lp:~laney/ubuntuone-credentials/multiarch-common
Merge into: lp:ubuntuone-credentials
Diff against target: 23 lines (+3/-3)
1 file modified
debian/control (+3/-3)
To merge this branch: bzr merge lp:~laney/ubuntuone-credentials/multiarch-common
Reviewer Review Type Date Requested Status
dobey (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+213804@code.launchpad.net

Commit message

Make ubuntuone-credentials-common Architecture: all and Multi-Arch: foreign. This allows cross-building of ubuntuone-credentials' reverse dependencies.

Description of the change

The files in this package are all arch-independent.

To post a comment you must log in.
92. By Iain Lane

Depend on -common (= ${source:Version})

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

CI Train doesn't handle it well when there's a manual distro upload, in particular this branch didn't include the changelog that was manually uploaded, so ironically CI Train complained that this branch couldn't be built because it didn't include the contents of the manual distro upload. I merged manually and pushed directly to trunk here:

http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-credentials/trunk/revision/91

For future reference, the easiest way to handle this (from the CI Train perspective) is to just do the MP, don't bother with the direct archive upload. Less risk of conflicts that way, thanks. (unless of course the issue is urgent)

Revision history for this message
dobey (dobey) wrote :

Robert, *please* do not commit direct to trunk in these cases in the future. Just comment on the MP and review it needs fixing for not containing all of the changes, instead.

Stuff like this happening is exactly why I am not fond of the CI train process, or allowing so many people to have direct commit access to trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-01-30 18:51:37 +0000
3+++ debian/control 2014-04-02 10:55:20 +0000
4@@ -20,8 +20,8 @@
5 Xs-Testsuite: autopkgtest
6
7 Package: ubuntuone-credentials-common
8-Architecture: any
9-Multi-Arch: same
10+Architecture: all
11+Multi-Arch: foreign
12 Pre-Depends:
13 multiarch-support,
14 ${misc:Pre-Depends},
15@@ -68,7 +68,7 @@
16 ${misc:Pre-Depends},
17 Depends:
18 signon-plugin-password,
19- ubuntuone-credentials-common (= ${binary:Version}),
20+ ubuntuone-credentials-common (= ${source:Version}),
21 ${misc:Depends},
22 ${shlibs:Depends},
23 Description: Ubuntu One authentication library

Subscribers

People subscribed via source and target branches

to all changes: