Merge lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1 into lp:~ubuntu-desktop/avahi/ubuntu
| Status: | Merged |
|---|---|
| Merged at revision: | 40 |
| Proposed branch: | lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1 |
| Merge into: | lp:~ubuntu-desktop/avahi/ubuntu |
| Diff against target: |
372 lines (+81/-110) 12 files modified
debian/avahi-autoipd.maintscript (+2/-0) debian/avahi-autoipd.postinst (+3/-25) debian/avahi-autoipd.preinst (+0/-19) debian/avahi-daemon.postinst (+4/-12) debian/avahi-dnsconfd.maintscript (+1/-0) debian/avahi-dnsconfd.preinst (+0/-32) debian/changelog (+49/-0) debian/control (+12/-10) debian/libavahi-ui-gtk3-0.symbols (+4/-4) debian/libavahi-ui0.symbols (+4/-4) debian/pyversions (+0/-1) debian/rules (+2/-3) |
| To merge this branch: | bzr merge lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Desktop | 2012-05-14 | Pending | |
| Ubuntu Sponsors Team | 2012-05-14 | Pending | |
|
Review via email:
|
|||
| Sebastien Bacher (seb128) wrote : | # |
| Sebastien Bacher (seb128) wrote : | # |
the udeb is still required apparently, it would be nice if the change was sent to the BTS though, Colin (he introduced the diff) said he can do it in the next days so maybe check with him to not dup work if you want to do that
| Iain Lane (laney) wrote : | # |
CFLAGS> I don't see any difference in the build with this change or not, and I think it is implied by using compat 9 ("All of the dh_auto_* debhelper programs and dh set environment variables listed by dpkg-buildflags"), so let's drop it.
systemd> Shouldn't be a problem. Lots of packages already ship files in /lib/systemd, and I don't see how this could cause us harm. I don't even see how it could be harmful to ship the symlinks into /etc (I see rsylog does this on my system), but it wasn't any work to keep this change.
udeb> I'll let Colin follow up, but if he doesn't get around to it then I'll ping next week


Thanks for the work Iain, just looking over for today but I've some comments,questions:
- do we still need the udeb for the installer with openstack?
- is the CFLAGS change something that could go to Debian?
- does it hurt in any way to ship systemd files if we don't use it?
(I realize that you didn't come with those changes but still it would be could to revisit if they are needed)