Merge lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1 into lp:~ubuntu-desktop/avahi/ubuntu

Proposed by Iain Lane on 2012-05-14
Status: Merged
Merged at revision: 40
Proposed branch: lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1
Merge into: lp:~ubuntu-desktop/avahi/ubuntu
Diff against target: 372 lines (+81/-110)
12 files modified
debian/avahi-autoipd.maintscript (+2/-0)
debian/avahi-autoipd.postinst (+3/-25)
debian/avahi-autoipd.preinst (+0/-19)
debian/avahi-daemon.postinst (+4/-12)
debian/avahi-dnsconfd.maintscript (+1/-0)
debian/avahi-dnsconfd.preinst (+0/-32)
debian/changelog (+49/-0)
debian/control (+12/-10)
debian/libavahi-ui-gtk3-0.symbols (+4/-4)
debian/libavahi-ui0.symbols (+4/-4)
debian/pyversions (+0/-1)
debian/rules (+2/-3)
To merge this branch: bzr merge lp:~laney/ubuntu/quantal/avahi/merge-0.6.31-1
Reviewer Review Type Date Requested Status
Ubuntu Desktop 2012-05-14 Pending
Ubuntu Sponsors Team 2012-05-14 Pending
Review via email: mp+105636@code.launchpad.net
To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Thanks for the work Iain, just looking over for today but I've some comments,questions:

- do we still need the udeb for the installer with openstack?
- is the CFLAGS change something that could go to Debian?
- does it hurt in any way to ship systemd files if we don't use it?

(I realize that you didn't come with those changes but still it would be could to revisit if they are needed)

Sebastien Bacher (seb128) wrote :

the udeb is still required apparently, it would be nice if the change was sent to the BTS though, Colin (he introduced the diff) said he can do it in the next days so maybe check with him to not dup work if you want to do that

Iain Lane (laney) wrote :

CFLAGS> I don't see any difference in the build with this change or not, and I think it is implied by using compat 9 ("All of the dh_auto_* debhelper programs and dh set environment variables listed by dpkg-buildflags"), so let's drop it.

systemd> Shouldn't be a problem. Lots of packages already ship files in /lib/systemd, and I don't see how this could cause us harm. I don't even see how it could be harmful to ship the symlinks into /etc (I see rsylog does this on my system), but it wasn't any work to keep this change.

udeb> I'll let Colin follow up, but if he doesn't get around to it then I'll ping next week

43. By Iain Lane on 2012-05-22

Drop change:

Pass CFLAGS from the environment through to configure. Seems to be no
longer necessary with the move to compat 9.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/avahi-autoipd.maintscript'
2--- debian/avahi-autoipd.maintscript 1970-01-01 00:00:00 +0000
3+++ debian/avahi-autoipd.maintscript 2012-05-22 21:34:20 +0000
4@@ -0,0 +1,2 @@
5+mv_conffile /etc/dhcp3/dhclient-enter-hooks.d/avahi-autoipd /etc/dhcp/dhclient-enter-hooks.d/avahi-autoipd 0.6.25-3 avahi-autoipd
6+mv_conffile /etc/dhcp3/dhclient-exit-hooks.d/zzz_avahi-autoipd /etc/dhcp/dhclient-exit-hooks.d/zzz_avahi-autoipd 0.6.25-3 avahi-autoipd
7
8=== modified file 'debian/avahi-autoipd.postinst'
9--- debian/avahi-autoipd.postinst 2011-02-24 17:16:33 +0000
10+++ debian/avahi-autoipd.postinst 2012-05-22 21:34:20 +0000
11@@ -2,33 +2,11 @@
12
13 set -e
14
15-# Move a conffile without triggering a dpkg question
16-mv_conffile() {
17- local OLDCONFFILE="$1"
18- local NEWCONFFILE="$2"
19-
20- [ -e "$OLDCONFFILE" ] || return 0
21-
22- echo "Preserving user changes to $NEWCONFFILE ..."
23- mv -f "$NEWCONFFILE" "$NEWCONFFILE".dpkg-new
24- mv -f "$OLDCONFFILE" "$NEWCONFFILE"
25-}
26-
27 case "$1" in
28 configure)
29- if ! getent passwd avahi-autoipd >/dev/null; then
30- adduser --disabled-password --quiet --system \
31- --home /var/lib/avahi-autoipd \
32- --gecos "Avahi autoip daemon" --group avahi-autoipd
33- fi
34-
35- # When upgradig from previous versions move dhclient hooks to new location
36- if dpkg --compare-versions "$2" lt "0.6.27-3ubuntu1"; then
37- mv_conffile "/etc/dhcp3/dhclient-enter-hooks.d/avahi-autoipd" \
38- "/etc/dhcp/dhclient-enter-hooks.d/avahi-autoipd"
39- mv_conffile "/etc/dhcp3/dhclient-exit-hooks.d/zzz_avahi-autoipd" \
40- "/etc/dhcp/dhclient-exit-hooks.d/zzz_avahi-autoipd"
41- fi
42+ adduser --disabled-password --quiet --system \
43+ --home /var/lib/avahi-autoipd \
44+ --gecos "Avahi autoip daemon" --group avahi-autoipd
45
46 # FIXME: restart it somehow... SIGHUP?
47 ;;
48
49=== modified file 'debian/avahi-autoipd.preinst'
50--- debian/avahi-autoipd.preinst 2011-02-24 17:16:33 +0000
51+++ debian/avahi-autoipd.preinst 2012-05-22 21:34:20 +0000
52@@ -2,27 +2,8 @@
53
54 set -e
55
56-# Prepare to move a conffile without triggering a dpkg question
57-prep_mv_conffile() {
58- local PKGNAME="$1"
59- local CONFFILE="$2"
60-
61- [ -e "$CONFFILE" ] || return 0
62-
63- local md5sum="$(md5sum $CONFFILE | sed -e 's/ .*//')"
64- local old_md5sum="$(dpkg-query -W -f='${Conffiles}' $PKGNAME | \
65- sed -n -e "\' $CONFFILE ' { s/ obsolete$//; s/.* //; p }")"
66- if [ "$md5sum" = "$old_md5sum" ]; then
67- rm -f "$CONFFILE"
68- fi
69-}
70-
71 case "$1" in
72 install|upgrade)
73- if dpkg --compare-versions "$2" lt "0.6.27-3ubuntu1"; then
74- prep_mv_conffile avahi-autoipd "/etc/dhcp3/dhclient-enter-hooks.d/avahi-autoipd"
75- prep_mv_conffile avahi-autoipd "/etc/dhcp3/dhclient-exit-hooks.d/zzz_avahi-autoipd"
76- fi
77 # Remove compat symlinks for dhcp3-client which might have been
78 # created during upgrades.
79 if dpkg --compare-versions "$2" lt "0.6.28-3"; then
80
81=== modified file 'debian/avahi-daemon.postinst'
82--- debian/avahi-daemon.postinst 2010-12-06 15:31:43 +0000
83+++ debian/avahi-daemon.postinst 2012-05-22 21:34:20 +0000
84@@ -16,20 +16,12 @@
85
86 case "$1" in
87 configure)
88- if ! getent passwd avahi >/dev/null; then
89- adduser --disabled-password --quiet --system \
90- --home /var/run/avahi-daemon --no-create-home \
91- --gecos "Avahi mDNS daemon" --group avahi
92- fi
93- # If the Avahi user has the old home, change it
94- if ! getent passwd avahi | grep -q /var/run/avahi-daemon; then
95- usermod -d /var/run/avahi-daemon avahi
96- fi
97+ adduser --disabled-password --quiet --system \
98+ --home /var/run/avahi-daemon --no-create-home \
99+ --gecos "Avahi mDNS daemon" --group avahi
100
101 # Add the netdev group unless it's already there
102- if ! getent group netdev >/dev/null; then
103- addgroup --quiet --system netdev || true
104- fi
105+ addgroup --quiet --system netdev || true
106
107 # Ask the bus to reload the config file
108 if [ -x "/etc/init.d/dbus" ]; then
109
110=== added file 'debian/avahi-dnsconfd.maintscript'
111--- debian/avahi-dnsconfd.maintscript 1970-01-01 00:00:00 +0000
112+++ debian/avahi-dnsconfd.maintscript 2012-05-22 21:34:20 +0000
113@@ -0,0 +1,1 @@
114+rm_conffile /etc/default/avahi-dnsconfd 0.6.25-4 avahi-dnsconfd
115
116=== removed file 'debian/avahi-dnsconfd.preinst'
117--- debian/avahi-dnsconfd.preinst 2010-08-25 05:38:39 +0000
118+++ debian/avahi-dnsconfd.preinst 1970-01-01 00:00:00 +0000
119@@ -1,32 +0,0 @@
120-#!/bin/sh
121-
122-set -e
123-
124-# Remove a no-longer used conffile
125-rm_conffile() {
126- local PKGNAME="$1"
127- local CONFFILE="$2"
128-
129- [ -e "$CONFFILE" ] || return 0
130-
131- local md5sum="$(md5sum $CONFFILE | sed -e 's/ .*//')"
132- local old_md5sum="$(dpkg-query -W -f='${Conffiles}' $PKGNAME | \
133- sed -n -e "\' $CONFFILE ' { s/ obsolete$//; s/.* //; p }")"
134- if [ "$md5sum" != "$old_md5sum" ]; then
135- echo "Obsolete conffile $CONFFILE has been modified by you."
136- echo "Saving as $CONFFILE.dpkg-bak ..."
137- mv -f "$CONFFILE" "$CONFFILE".dpkg-bak
138- else
139- echo "Removing obsolete conffile $CONFFILE ..."
140- rm -f "$CONFFILE"
141- fi
142-}
143-
144-case "$1" in
145-install|upgrade)
146- if dpkg --compare-versions "$2" lt "0.6.26-1"; then
147- rm_conffile avahi-dnsconfd "/etc/default/avahi-dnsconfd"
148- fi
149-esac
150-
151-#DEBHELPER#
152
153=== modified file 'debian/changelog'
154--- debian/changelog 2011-10-18 03:51:07 +0000
155+++ debian/changelog 2012-05-22 21:34:20 +0000
156@@ -1,3 +1,52 @@
157+avahi (0.6.31-1ubuntu1) UNRELEASED; urgency=low
158+
159+ * Merge with Debian unstable. Remaining changes:
160+ - debian/control: Add versioned dependency on the dbus that satisfies our
161+ upstart job dependency.
162+ - Add udebs corresponding to libavahi-common3 and libavahi-core7, so
163+ that we can use them for Eucalyptus integration in the installer.
164+ - Add debian/avahi-daemon.upstart, debian/avahi-dnsconfd.upstart
165+ - debian/avahi-{daemon,dnsconfd}.links: Remove systemd configuration
166+ symlinks.
167+ * Dropped changes
168+ - debian/avahi-autoipd.{pre,post}inst: Adjust package versions for conffile
169+ migration for the version when Ubuntu did the DHCP4 migration. We're now
170+ one LTS cycle since this, so there's no need to keep code paths for this
171+ upgrade.
172+ - Build with CFLAGS=-UGTK_DISABLE_DEPRECATED due to deprecation of
173+ gtk_vbox_new. No longer necessary.
174+ - Pass CFLAGS from the environment through to configure. Seems to be no
175+ longer necessary with the move to compat 9.
176+
177+ -- Iain Lane <iain.lane@canonical.com> Tue, 22 May 2012 22:21:27 +0100
178+
179+avahi (0.6.31-1) unstable; urgency=low
180+
181+ * New upstream release.
182+ * Mark private stdb_* symbols in libavahi-ui and libavahi-ui-gtk3 as
183+ optional.
184+ * Bump Build-Depends on debhelper to (>= 9).
185+ * Bump Standards-Version to 3.9.3. No further changes.
186+ * Use new dh_installdeb maintscript facility to (re)move the old conffiles
187+ for avahi-autoipd and avahi-dnsconfd.
188+
189+ -- Michael Biebl <biebl@debian.org> Sun, 04 Mar 2012 05:23:49 +0100
190+
191+avahi (0.6.30-6) unstable; urgency=low
192+
193+ * Switch to dh_python2. (Closes: #637552)
194+ * Simplify postinst for avahi-autoipd and avahi-daemon.
195+ * Rebuild to enable hardened build flags. (Closes: #655188)
196+ * Use term GLib consistently in the package description. (Closes: #633783)
197+
198+ -- Michael Biebl <biebl@debian.org> Tue, 10 Jan 2012 00:59:49 +0100
199+
200+avahi (0.6.30-5ubuntu2) precise; urgency=low
201+
202+ * Build using dh_python2.
203+
204+ -- Matthias Klose <doko@ubuntu.com> Sat, 17 Dec 2011 12:06:42 +0100
205+
206 avahi (0.6.30-5ubuntu1) precise; urgency=low
207
208 * Merge from Debian testing. Remaining changes:
209
210=== modified file 'debian/control'
211--- debian/control 2011-07-07 09:49:46 +0000
212+++ debian/control 2012-05-22 21:34:20 +0000
213@@ -7,9 +7,8 @@
214 Sebastian Dröge <slomo@debian.org>,
215 Loic Minier <lool@dooz.org>,
216 Michael Biebl <biebl@debian.org>
217-Build-Depends: debhelper (>= 8.1.3),
218+Build-Depends: debhelper (>= 9),
219 pkg-config,
220- python-support (>= 0.6),
221 libcap-dev (>= 1:2.16) [linux-any],
222 libgdbm-dev,
223 libglib2.0-dev (>= 2.4),
224@@ -18,14 +17,15 @@
225 libexpat-dev,
226 libdaemon-dev (>= 0.11),
227 libdbus-1-dev (>= 0.60),
228- python-all-dev (>= 2.3.5-11),
229+ python-all-dev (>= 2.6.6-3~),
230 python-gdbm (>= 2.4.3),
231 python-dbus,
232 python-gtk2 (>= 2.8.6-2),
233 libqt4-dev,
234 xmltoman,
235 intltool (>= 0.35.0)
236-Standards-Version: 3.9.2
237+X-Python-Version: >= 2.4
238+Standards-Version: 3.9.3
239 XS-Debian-Vcs-Git: git://git.debian.org/git/pkg-utopia/avahi.git
240 XS-Debian-Vcs-Browser: http://git.debian.org/?p=pkg-utopia/avahi.git;a=summary
241 Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/avahi/ubuntu
242@@ -58,6 +58,7 @@
243 Package: avahi-dnsconfd
244 Section: net
245 Architecture: any
246+Pre-Depends: ${misc:Pre-Depends}
247 Depends: ${shlibs:Depends},
248 ${misc:Depends},
249 avahi-daemon,
250@@ -77,6 +78,7 @@
251 Package: avahi-autoipd
252 Section: net
253 Architecture: linux-any
254+Pre-Depends: ${misc:Pre-Depends}
255 Depends: ${shlibs:Depends},
256 ${misc:Depends},
257 adduser
258@@ -198,7 +200,7 @@
259 of Avahis components and client applications.
260
261 Package: libavahi-common3-udeb
262-XC-Package-Type: udeb
263+Package-Type: udeb
264 Section: debian-installer
265 Architecture: any
266 Depends: ${shlibs:Depends},
267@@ -247,7 +249,7 @@
268 shoudl use libavahi-client-dev which interacts with the avahi daemon.
269
270 Package: libavahi-core7-udeb
271-XC-Package-Type: udeb
272+Package-Type: udeb
273 Section: debian-installer
274 Architecture: any
275 Depends: ${shlibs:Depends},
276@@ -295,7 +297,7 @@
277 ${misc:Depends}
278 Pre-Depends: ${misc:Pre-Depends}
279 Multi-Arch: same
280-Description: Avahi glib integration library
281+Description: Avahi GLib integration library
282 Avahi is a fully LGPL framework for Multicast DNS Service Discovery.
283 It allows programs to publish and discover services and hosts
284 running on a local network with no specific configuration. For
285@@ -303,7 +305,7 @@
286 print to, files to look at and people to talk to.
287 .
288 This library contains the interface to integrate the Avahi libraries
289- into a GLIB main loop application, including GTK+ applications.
290+ into a GLib main loop application, including GTK+ applications.
291
292 Package: libavahi-glib-dev
293 Section: libdevel
294@@ -312,7 +314,7 @@
295 ${misc:Depends},
296 libglib2.0-dev,
297 libavahi-common-dev
298-Description: Development headers for the Avahi glib integration library
299+Description: Development headers for the Avahi GLib integration library
300 Avahi is a fully LGPL framework for Multicast DNS Service Discovery.
301 It allows programs to publish and discover services and hosts
302 running on a local network with no specific configuration. For
303@@ -320,7 +322,7 @@
304 print to, files to look at and people to talk to.
305 .
306 This package contains the development headers for the interface
307- to integrate the Avahi libraries into a GLIB main loop application,
308+ to integrate the Avahi libraries into a GLib main loop application,
309 including GTK+ applications.
310
311 Package: libavahi-gobject0
312
313=== modified file 'debian/libavahi-ui-gtk3-0.symbols'
314--- debian/libavahi-ui-gtk3-0.symbols 2011-05-16 19:41:44 +0000
315+++ debian/libavahi-ui-gtk3-0.symbols 2012-05-22 21:34:20 +0000
316@@ -22,7 +22,7 @@
317 aui_service_dialog_set_service_name@Base 0.6.30
318 aui_service_dialog_set_service_type@Base 0.6.30
319 aui_service_dialog_set_service_type_name@Base 0.6.30
320- stdb_getent@Base 0.6.30
321- stdb_lookup@Base 0.6.30
322- stdb_setent@Base 0.6.30
323- stdb_shutdown@Base 0.6.30
324+ (optional)stdb_getent@Base 0.6.30
325+ (optional)stdb_lookup@Base 0.6.30
326+ (optional)stdb_setent@Base 0.6.30
327+ (optional)stdb_shutdown@Base 0.6.30
328
329=== modified file 'debian/libavahi-ui0.symbols'
330--- debian/libavahi-ui0.symbols 2009-06-04 04:17:14 +0000
331+++ debian/libavahi-ui0.symbols 2012-05-22 21:34:20 +0000
332@@ -22,7 +22,7 @@
333 aui_service_dialog_set_service_name@Base 0.6.21
334 aui_service_dialog_set_service_type@Base 0.6.21
335 aui_service_dialog_set_service_type_name@Base 0.6.22
336- stdb_getent@Base 0.6.21
337- stdb_lookup@Base 0.6.21
338- stdb_setent@Base 0.6.21
339- stdb_shutdown@Base 0.6.21
340+ (optional)stdb_getent@Base 0.6.21
341+ (optional)stdb_lookup@Base 0.6.21
342+ (optional)stdb_setent@Base 0.6.21
343+ (optional)stdb_shutdown@Base 0.6.21
344
345=== removed file 'debian/pyversions'
346--- debian/pyversions 2009-06-04 04:17:14 +0000
347+++ debian/pyversions 1970-01-01 00:00:00 +0000
348@@ -1,1 +0,0 @@
349-2.4-
350
351=== modified file 'debian/rules'
352--- debian/rules 2011-09-21 08:01:42 +0000
353+++ debian/rules 2012-05-22 21:34:20 +0000
354@@ -1,7 +1,7 @@
355 #!/usr/bin/make -f
356
357 %:
358- dh $@
359+ dh $@ --with python2
360
361 DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
362
363@@ -20,8 +20,7 @@
364 --disable-monodoc \
365 --disable-qt3 \
366 --enable-gtk3 \
367- --with-systemdsystemunitdir=/lib/systemd/system \
368- CFLAGS="$(CFLAGS) -UGTK_DISABLE_DEPRECATED"
369+ --with-systemdsystemunitdir=/lib/systemd/system
370
371 override_dh_auto_build:
372 dh_auto_build

Subscribers

People subscribed via source and target branches

to all changes: