Code review comment for lp:~laney/ubuntu-terminal-app/notshowin-unity

On Tue, Sep 27, 2016 at 11:24:25AM -0000, Iain Lane wrote:
> On Tue, Sep 27, 2016 at 11:08:32AM -0000, Alan Pope 🍺🐧🐱 wrote:
> > Interestingly this fails click-review, if built as a click (which we do for the phone, although armhf, not amd64 as in the example below)...
> >
> > Now executing: click-review ./com.ubuntu.terminal_0.7.217_amd64.click
> > Errors
> > ------
> > - desktop:validates:terminal
> > did not validate: (ValidationError in file '/tmp/review-pp96fg9l/com.ubuntu.terminal.desktop':
> > - 'Unity7' is not a registered OnlyShowIn value )
> > http://askubuntu.com/questions/417377/what-does-desktop-validates-mean/417378
>
> Sigh, desktop-file-validate has a whitelist of allowed names.

See https://bugs.freedesktop.org/show_bug.cgi?id=97947

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]