Merge lp:~laney/ubuntu-system-settings/up-from-panels into lp:ubuntu-system-settings

Proposed by Iain Lane
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 436
Merged at revision: 436
Proposed branch: lp:~laney/ubuntu-system-settings/up-from-panels
Merge into: lp:ubuntu-system-settings
Diff against target: 19 lines (+1/-2)
1 file modified
src/qml/MainWindow.qml (+1/-2)
To merge this branch: bzr merge lp:~laney/ubuntu-system-settings/up-from-panels
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+189669@code.launchpad.net

Commit message

Always push the main page onto the pageStack so that we can go back to the index after being launched to an individual panel.

Description of the change

Always push the main page onto the pageStack so that we can go back to the index after being launched to an individual panel.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/MainWindow.qml'
2--- src/qml/MainWindow.qml 2013-10-02 13:55:02 +0000
3+++ src/qml/MainWindow.qml 2013-10-07 17:24:23 +0000
4@@ -31,6 +31,7 @@
5
6 Component.onCompleted: {
7 i18n.domain = "ubuntu-system-settings"
8+ pageStack.push(mainPage)
9 if (defaultPlugin) {
10 var plugin = pluginManager.getByName(defaultPlugin)
11 if (plugin) {
12@@ -43,8 +44,6 @@
13 console.log("Plugin " + defaultPlugin + " does not exist.")
14 Qt.quit()
15 }
16- } else {
17- pageStack.push(mainPage)
18 }
19 }
20

Subscribers

People subscribed via source and target branches