lp:~laney/ubuntu-system-settings/measure-real-directory-size

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-system-settings at revision 397

Sebastien Bacher (community): Approve on 2013-09-27

PS Jenkins bot: Approve (continuous-integration) on 2013-09-27

Allison Karlitskaya: Pending requested 2013-09-20

Diff: 629 lines (+369/-43)

9 files modified

debian/control (+1/-1)
plugins/about/Storage.qml (+77/-24)
plugins/about/StorageBar.qml (+39/-13)
plugins/about/StorageItem.qml (+10/-2)
plugins/about/about.pro (+2/-1)
plugins/about/click.cpp (+9/-1)
plugins/about/click.h (+2/-0)
plugins/about/storageabout.cpp (+187/-1)
plugins/about/storageabout.h (+42/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1205297: storage: should get the disk size of the xdg directories	High	Fix Released
Bug #1228419: Storage size of files and folders	High	Fix Committed

Link a bug report

Related blueprints

376. By Iain Lane on 2013-09-26

Drop the old way of getting device names; make new way more robust

375. By Iain Lane on 2013-09-26

Debugging

374. By Iain Lane on 2013-09-26

Can get the device path more directly

373. By Iain Lane on 2013-09-26

Add API to only count each device once

372. By Iain Lane on 2013-09-25

Explicitly initialise the pointer to NULL

371. By Iain Lane on 2013-09-25

Some cleanups found by Charles Kerr (thanks)

  - Rename 'finished' to 'running' now that the logic has changed
  - Free a glib string that was leaked
  - Delete the 'data' structure if we're cancelled
  - Keep the cancellable if it already exists (for if populateSizes ever gets
    called more than once)

370. By Iain Lane on 2013-09-25

Use g_clear_object()

369. By Iain Lane on 2013-09-25

Free the GError

368. By Iain Lane on 2013-09-25

Use a cancellable to stop the operation if we leave the screen to avoid crashes

Also remove the magic "4" by incrementing when an op is dispatched and decrementing when it finishes.

367. By Iain Lane on 2013-09-25

Fall back to considering / only if all drives are unknown