Merge lp:~laney/ubuntu-system-settings/fix-translated-search into lp:ubuntu-system-settings
Proposed by
Iain Lane
Status: | Merged |
---|---|
Approved by: | Sebastien Bacher |
Approved revision: | 493 |
Merged at revision: | 495 |
Proposed branch: | lp:~laney/ubuntu-system-settings/fix-translated-search |
Merge into: | lp:ubuntu-system-settings |
Diff against target: |
23 lines (+4/-3) 1 file modified
src/item-model.cpp (+4/-3) |
To merge this branch: | bzr merge lp:~laney/ubuntu-system-settings/fix-translated-search |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+195610@code.launchpad.net |
Commit message
When generating the translated list of keywords, keep the byte array alive for as long as it's needed.
Description of the change
When generating the translated list of keywords, keep the byte array alive for as long as it's needed.
Otherwise it can be freed and then we get invalid reads which breaks the translations and means you can't search for the translated text.
To post a comment you must log in.
PASSED: Continuous integration, rev:493 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/508/ jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- trusty- amd64-ci/ 24 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- trusty- armhf-ci/ 12 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- trusty- armhf-ci/ 12/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- trusty- i386-ci/ 11
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ ubuntu- system- settings- ci/508/ rebuild
http://