Merge lp:~laney/ubuntu-system-settings/background-no-toolbar-close into lp:ubuntu-system-settings

Proposed by Iain Lane
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 644
Merged at revision: 645
Proposed branch: lp:~laney/ubuntu-system-settings/background-no-toolbar-close
Merge into: lp:ubuntu-system-settings
Diff against target: 12 lines (+2/-0)
1 file modified
plugins/background/Wallpapers.qml (+2/-0)
To merge this branch: bzr merge lp:~laney/ubuntu-system-settings/background-no-toolbar-close
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher (community) Approve
Review via email: mp+209647@code.launchpad.net

Commit message

background selector: lock the toolbar open, per the design

To post a comment you must log in.
644. By Iain Lane

locked too

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, bonus point if you --fixes lp:1288361 (you can probably uncommit, commit again and push --overwrite)

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

On Thu, Mar 06, 2014 at 11:14:12AM -0000, Sebastien Bacher wrote:
> Review: Approve
>
> Thanks, bonus point if you --fixes lp:1288361 (you can probably uncommit, commit again and push --overwrite)

Oh yeah, I forgot (but I can just link the branch, it does the same
thing)

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Sebastien Bacher (seb128) wrote :

> Oh yeah, I forgot (but I can just link the branch, it does the same thing)

is the CI release magic going to add the bug reference in the changelog as well if you do that?

Revision history for this message
Sebastien Bacher (seb128) wrote :

(seems it does, approving then)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/background/Wallpapers.qml'
2--- plugins/background/Wallpapers.qml 2014-02-18 14:18:27 +0000
3+++ plugins/background/Wallpapers.qml 2014-03-06 11:11:39 +0000
4@@ -58,6 +58,8 @@
5 ToolbarButton {
6 action: selectDefaultPeer
7 }
8+ opened: true
9+ locked: true
10 }
11
12 UbuntuBackgroundPanel {

Subscribers

People subscribed via source and target branches