Code review comment for lp:~laney/ubuntu-system-settings/as-ringtone

Revision history for this message
Michael Terry (mterry) wrote :

Looks great to me, tested and it seems fine.

 * Are any changes against your component pending/needed to land the MP under review in a functional state and are those called out explicitly by the submitter?
 - No
 * Did you do exploratory testing related to the component you own with the MP changeset included?
 - No, but greeter uses similar code to interact with other settings
 * Has the submitter requested review by all the relevant teams/reviewers?
 - Yes
 * If you are the reviewer owning the component the MP is against, have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
 - N/A

review: Approve

« Back to merge proposal