Merge lp:~laney/ubuntu-dev-tools/debuild-no-debemail-1007042 into lp:~ubuntu-dev/ubuntu-dev-tools/trunk

Proposed by Iain Lane on 2012-06-13
Status: Merged
Merged at revision: 1322
Proposed branch: lp:~laney/ubuntu-dev-tools/debuild-no-debemail-1007042
Merge into: lp:~ubuntu-dev/ubuntu-dev-tools/trunk
Diff against target: 28 lines (+6/-1)
2 files modified
backportpackage (+3/-1)
debian/changelog (+3/-0)
To merge this branch: bzr merge lp:~laney/ubuntu-dev-tools/debuild-no-debemail-1007042
Reviewer Review Type Date Requested Status
Evan Broder 2012-06-13 Approve on 2012-06-17
Stefano Rivera Approve on 2012-06-17
Review via email: mp+110189@code.launchpad.net

Description of the Change

I don't know if this is the most pythonic way of achieving this, but I think it's what we want to do.

To post a comment you must log in.
Stefano Rivera (stefanor) wrote :

Pythonic enough for me (it's how I'd solve the problem).

review: Approve
Evan Broder (broder) wrote :

Looks fine to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backportpackage'
2--- backportpackage 2012-06-02 19:34:20 +0000
3+++ backportpackage 2012-06-13 22:24:22 +0000
4@@ -322,7 +322,9 @@
5 cmd.append('-sd')
6 if old_version:
7 cmd.append('-v%s' % old_version)
8- check_call(cmd, cwd=srcdir)
9+ env = os.environ.copy()
10+ del env['DEBEMAIL']
11+ check_call(cmd, cwd=srcdir, env=env)
12
13 fn_base = pkg.source + '_' + bp_version.split(':', 1)[-1]
14 changes = fn_base + '_source.changes'
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2012-06-06 13:55:08 +0000
18+++ debian/changelog 2012-06-13 22:24:22 +0000
19@@ -4,6 +4,9 @@
20 * backportpackage: Fix filenames searched when looking for existing
21 .orig.tar.foo files (to determine if we need to upload it again or not).
22 (LP: #1007908)
23+ * backportpackage: Unset DEBEMAIL when building source package. Fixes error
24+ when building backports for packages with no Ubuntu changes. (LP:
25+ #1007042)
26
27 [ Mathieu Trudel-Lapierre ]
28 * mk-sbuild: use and update messages to suggest using the source:$chroot way

Subscribers

People subscribed via source and target branches

to status/vote changes: