ubuntu-archive-tools

Merge lp:~laney/ubuntu-archive-tools/edit-acl-crash into lp:ubuntu-archive-tools

  1. edit-acl-crash
  2. Merge into trunk
Proposed by Iain Lane on 2014-09-22
Status: Merged
Merged at revision: 953
Proposed branch: lp:~laney/ubuntu-archive-tools/edit-acl-crash
Merge into: lp:ubuntu-archive-tools
Diff against target: 12 lines (+1/-1)
1 file modified
edit-acl (+1/-1)
To merge this branch: bzr merge lp:~laney/ubuntu-archive-tools/edit-acl-crash
Reviewer Review Type Date Requested Status
Brian Murray (community) Approve on 2015-05-01
Stéphane Graber 2014-09-22 Pending
Ubuntu Package Archive Administrators 2014-09-22 Pending
Review via email: mp+235471@code.launchpad.net

Commit Message

edit-acl: 'series' is a string

Description of the Change

laney@raleigh> edit-acl -s xdg-user-dirs -S utopic query
== All uploaders for package 'xdg-user-dirs' ==
Traceback (most recent call last):
  File "/home/laney/bin/ubuntu-archive-tools/edit-acl", line 713, in <module>
    main(options, args[0])
  File "/home/laney/bin/ubuntu-archive-tools/edit-acl", line 625, in main
    do_query(options)
  File "/home/laney/bin/ubuntu-archive-tools/edit-acl", line 218, in do_query
    print_perms(perms_component, series=series)
  File "/home/laney/bin/ubuntu-archive-tools/edit-acl", line 52, in print_perms
    desc[-1] += ' in %s' % series.name
AttributeError: 'unicode' object has no attribute 'name'

To post a comment you must log in.
Brian Murray (brian-murray) wrote :

This looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-acl'
2--- edit-acl 2014-09-08 22:16:19 +0000
3+++ edit-acl 2014-09-22 14:44:03 +0000
4@@ -48,7 +48,7 @@
5 if perm.component_name:
6 desc.append("component '%s'" % perm.component_name)
7 if series:
8- desc[-1] += ' in %s' % series.name
9+ desc[-1] += ' in %s' % series
10 if perm.package_set_name:
11 desc.append("package set '%s' in %s" % (perm.package_set_name,
12 perm.distro_series_name))

Subscribers

People subscribed via source and target branches