Merge lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary into lp:ubuntu-archive-scripts

Proposed by Iain Lane
Status: Merged
Merged at revision: 272
Proposed branch: lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary
Merge into: lp:ubuntu-archive-scripts
Diff against target: 61 lines (+14/-4)
2 files modified
generate-team-p-m (+10/-4)
templates/team-report.html (+4/-0)
To merge this branch: bzr merge lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Ubuntu Package Archive Administrators Pending
Review via email: mp+381810@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me, thanks for fixing it!

review: Approve
272. By Iain Lane

generate-team-p-m: Attribute binary-only migration items to the right team

We need to split on the / and look the first part (package name) up in the
mapping

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'generate-team-p-m'
2--- generate-team-p-m 2020-03-19 15:07:56 +0000
3+++ generate-team-p-m 2020-04-07 10:03:31 +0000
4@@ -206,7 +206,10 @@
5 if self._age is not None:
6 return self._age
7 else:
8- return self.data["policy_info"]["age"]["current-age"]
9+ try:
10+ return self.data["policy_info"]["age"]["current-age"]
11+ except KeyError:
12+ return -1
13
14 @age.setter
15 def age(self, val):
16@@ -249,7 +252,7 @@
17 # Missing component means main
18 if item.get('component', 'main') not in components:
19 continue
20- prob = Problem(kind='package-in-proposed', data=item, package_in_proposed=source_package_name)
21+ prob = Problem(kind='package-in-proposed', data=defaultdict(dict, item), package_in_proposed=source_package_name)
22 in_proposed_packages[source_package_name] = prob
23 prob.regressions = []
24 prob.waiting = []
25@@ -280,7 +283,9 @@
26 package_to_problems = defaultdict(list)
27
28 for problem in in_proposed_packages.values():
29- package_to_problems[problem.package_in_proposed].append(problem)
30+ # nautilus/riscv64 -> nautilus
31+ pkg = problem.package_in_proposed.split('/')[0]
32+ package_to_problems[pkg].append(problem)
33 for regression in problem.regressions:
34 if regression.blocking not in in_proposed_packages:
35 continue
36@@ -307,7 +312,8 @@
37 else:
38 subscribers = get_subscribers_json(set(package_to_problems), args.subscribers_json)
39 for p in set(package_to_problems):
40- if p not in subscribers:
41+ pkg = p.split('/')[0]
42+ if pkg not in subscribers:
43 subscribers[p] = ['unknown']
44
45 all_teams = set()
46
47=== modified file 'templates/team-report.html'
48--- templates/team-report.html 2020-03-05 10:14:14 +0000
49+++ templates/team-report.html 2020-04-07 10:03:31 +0000
50@@ -43,7 +43,11 @@
51 {% else %}
52 in proposed for
53 {% endif %}
54+ {% if prob.age == -1 %}
55+ an unknown number of days
56+ {% else %}
57 {{ ngettext("%(num)d day", "%(num)d days", prob.age|int) }}
58+ {% endif %}
59 <ul>
60 {% if d["policy_info"]["update-excuse"] %}
61 <li>Excuses bugs:

Subscribers

People subscribed via source and target branches