Merge lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary into lp:ubuntu-archive-scripts

Proposed by Iain Lane
Status: Merged
Merged at revision: 272
Proposed branch: lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary
Merge into: lp:ubuntu-archive-scripts
Diff against target: 61 lines (+14/-4)
2 files modified
generate-team-p-m (+10/-4)
templates/team-report.html (+4/-0)
To merge this branch: bzr merge lp:~laney/ubuntu-archive-scripts/generate-team-p-m-binary
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Ubuntu Package Archive Administrators Pending
Review via email: mp+381810@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me, thanks for fixing it!

review: Approve
272. By Iain Lane

generate-team-p-m: Attribute binary-only migration items to the right team

We need to split on the / and look the first part (package name) up in the
mapping

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'generate-team-p-m'
--- generate-team-p-m 2020-03-19 15:07:56 +0000
+++ generate-team-p-m 2020-04-07 10:03:31 +0000
@@ -206,7 +206,10 @@
206 if self._age is not None:206 if self._age is not None:
207 return self._age207 return self._age
208 else:208 else:
209 return self.data["policy_info"]["age"]["current-age"]209 try:
210 return self.data["policy_info"]["age"]["current-age"]
211 except KeyError:
212 return -1
210213
211 @age.setter214 @age.setter
212 def age(self, val):215 def age(self, val):
@@ -249,7 +252,7 @@
249 # Missing component means main252 # Missing component means main
250 if item.get('component', 'main') not in components:253 if item.get('component', 'main') not in components:
251 continue254 continue
252 prob = Problem(kind='package-in-proposed', data=item, package_in_proposed=source_package_name)255 prob = Problem(kind='package-in-proposed', data=defaultdict(dict, item), package_in_proposed=source_package_name)
253 in_proposed_packages[source_package_name] = prob256 in_proposed_packages[source_package_name] = prob
254 prob.regressions = []257 prob.regressions = []
255 prob.waiting = []258 prob.waiting = []
@@ -280,7 +283,9 @@
280 package_to_problems = defaultdict(list)283 package_to_problems = defaultdict(list)
281284
282 for problem in in_proposed_packages.values():285 for problem in in_proposed_packages.values():
283 package_to_problems[problem.package_in_proposed].append(problem)286 # nautilus/riscv64 -> nautilus
287 pkg = problem.package_in_proposed.split('/')[0]
288 package_to_problems[pkg].append(problem)
284 for regression in problem.regressions:289 for regression in problem.regressions:
285 if regression.blocking not in in_proposed_packages:290 if regression.blocking not in in_proposed_packages:
286 continue291 continue
@@ -307,7 +312,8 @@
307 else:312 else:
308 subscribers = get_subscribers_json(set(package_to_problems), args.subscribers_json)313 subscribers = get_subscribers_json(set(package_to_problems), args.subscribers_json)
309 for p in set(package_to_problems):314 for p in set(package_to_problems):
310 if p not in subscribers:315 pkg = p.split('/')[0]
316 if pkg not in subscribers:
311 subscribers[p] = ['unknown']317 subscribers[p] = ['unknown']
312318
313 all_teams = set()319 all_teams = set()
314320
=== modified file 'templates/team-report.html'
--- templates/team-report.html 2020-03-05 10:14:14 +0000
+++ templates/team-report.html 2020-04-07 10:03:31 +0000
@@ -43,7 +43,11 @@
43 {% else %}43 {% else %}
44 in proposed for44 in proposed for
45 {% endif %}45 {% endif %}
46 {% if prob.age == -1 %}
47 an unknown number of days
48 {% else %}
46 {{ ngettext("%(num)d day", "%(num)d days", prob.age|int) }}49 {{ ngettext("%(num)d day", "%(num)d days", prob.age|int) }}
50 {% endif %}
47 <ul>51 <ul>
48 {% if d["policy_info"]["update-excuse"] %}52 {% if d["policy_info"]["update-excuse"] %}
49 <li>Excuses bugs:53 <li>Excuses bugs:

Subscribers

People subscribed via source and target branches