Merge lp:~laney/ubiquity/lp1508121 into lp:ubiquity

Proposed by Iain Lane
Status: Merged
Merged at revision: 6347
Proposed branch: lp:~laney/ubiquity/lp1508121
Merge into: lp:ubiquity
Diff against target: 36 lines (+8/-4)
1 file modified
scripts/install.py (+8/-4)
To merge this branch: bzr merge lp:~laney/ubiquity/lp1508121
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+275074@code.launchpad.net

Description of the change

Ignore ':arch' in manifest files in the other place too

We were removing files from packages we wanted to keep

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

La la la, horrible factoring but not your fault.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/install.py'
2--- scripts/install.py 2014-04-09 13:13:35 +0000
3+++ scripts/install.py 2015-10-20 17:18:47 +0000
4@@ -220,24 +220,28 @@
5 with open(manifest_remove) as manifest_file:
6 for line in manifest_file:
7 if line.strip() != '' and not line.startswith('#'):
8- difference.add(line.split()[0])
9+ pkg = line.split(':')[0]
10+ difference.add(pkg.split()[0])
11 live_packages = set()
12 with open(manifest) as manifest_file:
13 for line in manifest_file:
14 if line.strip() != '' and not line.startswith('#'):
15- live_packages.add(line.split()[0])
16+ pkg = line.split(':')[0]
17+ live_packages.add(pkg.split()[0])
18 desktop_packages = live_packages - difference
19 elif os.path.exists(manifest_desktop) and os.path.exists(manifest):
20 desktop_packages = set()
21 with open(manifest_desktop) as manifest_file:
22 for line in manifest_file:
23 if line.strip() != '' and not line.startswith('#'):
24- desktop_packages.add(line.split()[0])
25+ pkg = line.split(':')[0]
26+ desktop_packages.add(pkg.split()[0])
27 live_packages = set()
28 with open(manifest) as manifest_file:
29 for line in manifest_file:
30 if line.strip() != '' and not line.startswith('#'):
31- live_packages.add(line.split()[0])
32+ pkg = line.split(':')[0]
33+ live_packages.add(pkg.split()[0])
34 difference = live_packages - desktop_packages
35 else:
36 difference = set()

Subscribers

People subscribed via source and target branches

to status/vote changes: