Merge lp:~laney/ubiquity/gtk320 into lp:ubiquity

Proposed by Iain Lane
Status: Merged
Merged at revision: 6465
Proposed branch: lp:~laney/ubiquity/gtk320
Merge into: lp:ubiquity
Diff against target: 72 lines (+16/-8)
4 files modified
debian/control (+1/-1)
tests/test_usersetup.py (+1/-0)
ubiquity/frontend/gtk_ui.py (+13/-7)
ubiquity/plugins/ubi-wireless.py (+1/-0)
To merge this branch: bzr merge lp:~laney/ubiquity/gtk320
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+300892@code.launchpad.net

Description of the change

Port the CSS to work with GTK 3.20, which changed how the selectors work.

The biggest change was to the progress pill thingies. Please see if you think they look good enough now.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

I forgot to say - to test this, add ppa:ubuntu-desktop/gtk320 in a live session, install this ubiquity, and restart lightdm.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-03-15 14:18:44 +0000
3+++ debian/control 2016-07-22 14:16:39 +0000
4@@ -45,7 +45,7 @@
5 Package: ubiquity-frontend-gtk
6 Architecture: amd64 arm64 armhf i386 powerpc ppc64el
7 Pre-Depends: ${misc:Pre-Depends}
8-Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0, gir1.2-pango-1.0, gir1.2-soup-2.4, gir1.2-vte-2.91, gir1.2-webkit2-4.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
9+Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0 (>= 3.20), gir1.2-pango-1.0, gir1.2-soup-2.4, gir1.2-vte-2.91, gir1.2-webkit2-4.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
10 Suggests: gnome-control-center | feh
11 Conflicts: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)
12 Replaces: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)
13
14=== modified file 'tests/test_usersetup.py'
15--- tests/test_usersetup.py 2013-02-19 11:33:07 +0000
16+++ tests/test_usersetup.py 2016-07-22 14:16:39 +0000
17@@ -91,6 +91,7 @@
18 def test_unicode(self):
19 # i18n needs to be imported to register ascii_transliterate
20 from ubiquity import i18n
21+ assert i18n # silence, pyflakes
22
23 self.gtk.controller.get_string = mock_get_string
24 heart = '♥'
25
26=== modified file 'ubiquity/frontend/gtk_ui.py'
27--- ubiquity/frontend/gtk_ui.py 2016-04-06 03:08:53 +0000
28+++ ubiquity/frontend/gtk_ui.py 2016-07-22 14:16:39 +0000
29@@ -256,18 +256,24 @@
30 # Make a thin Progress bar
31 provider = Gtk.CssProvider()
32 provider.load_from_data(b'''\
33- .inline-toolbar.toolbar {
34+ toolbar {
35 background: @theme_bg_color;
36 border-color: transparent;
37 border-width: 0px;
38 padding: 0px;
39 }
40- GtkProgressBar {
41- -GtkProgressBar-min-horizontal-bar-height : 10;
42- -GtkProgressBar-min-horizontal-bar-width : 10;
43- }
44- GtkPaned {
45- -GtkPaned-handle-size: 10;
46+ progressbar trough {
47+ min-height: 10px;
48+ min-width: 11px;
49+ border: none;
50+ }
51+ progressbar progress {
52+ min-height: 10px;
53+ border-radius: 4px;
54+ border: none;
55+ }
56+ paned separator {
57+ min-width: 10px;
58 }
59 ''')
60 Gtk.StyleContext.add_provider_for_screen(
61
62=== modified file 'ubiquity/plugins/ubi-wireless.py'
63--- ubiquity/plugins/ubi-wireless.py 2014-06-30 13:09:16 +0000
64+++ ubiquity/plugins/ubi-wireless.py 2016-07-22 14:16:39 +0000
65@@ -62,6 +62,7 @@
66 # as importing it as the side effect of registering
67 # NetworkManagerWidget which we DO use in the Wireless step UI.
68 from ubiquity.frontend.gtk_components import nmwidgets
69+ assert nmwidgets # silence, pyflakes
70
71 if self.is_automatic:
72 self.page = None

Subscribers

People subscribed via source and target branches

to status/vote changes: