Merge lp:~laney/terminator/gtk3.20-embedded-css into lp:terminator

[Iain Lane]

Update the selectors to include 3.20 compatibility too. This release moved to CSS nodes - all themes and application CSS have to be ported.

[Iain Lane (laney)]

Without this, the header in the notebook gets a transparent background - try in (e.g.) current zesty with Ambiance

[Stephen Boddy (stephen-j-boddy)]

Have you looked at the css files in the terminatorlib/themes subfolder? If I'm understanding what you're saying, then it sounds like some of those would need modifications too, to work properly with the newer Gtk versions.

[Iain Lane (laney)]

Nope, I didn't see those. But yes it looks like that's the case. Most of the selectors have to be rewritten for 3.20. Fortunately the online documentation is quite good in telling you exactly which CSS nodes each widget contains now.

[Stephen Boddy (stephen-j-boddy)]

Yeah, I'm a bit hit and miss with getting the selectors(?) right at the best of times. Doing it blindly for systems with newer software where I can't see the difference will be rather challenging. I'll probably leave it till people who get issues submit patches... unless... ;-) you want to be a diamond geezer and polish them up?

[Iain Lane (laney)]

On Wed, Feb 01, 2017 at 12:05:36PM -0000, Stephen Boddy wrote:
> Yeah, I'm a bit hit and miss with getting the selectors(?) right at the best of times. Doing it blindly for systems with newer software where I can't see the difference will be rather challenging. I'll probably leave it till people who get issues submit patches... unless... ;-) you want to be a diamond geezer and polish them up?

I could try if I knew what the CSS was attempting to do. I'm running
with just the fix in this MP currently, because the problem there is
extreeeeeeeemely obvious, and I don't see any real visual problems.
Presumably something annoyed someone enough in the past that they cooked
up these tweaks though.

I'd like it if you could review/merge this MP and then hopefully I or
someone else comes along and fixes the standalone CSS files in another
one. :)

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Stephen Boddy (stephen-j-boddy)]

No probs. Done.

review: Approve

=== modified file 'terminatorlib/terminator.py'
--- terminatorlib/terminator.py	2016-12-12 11:27:56 +0000
+++ terminatorlib/terminator.py	2017-02-01 11:07:57 +0000
@@ -404,7 +404,8 @@
             .terminator-terminal-window {
                 background-color: alpha(@theme_bg_color,0); }
 
-            .terminator-terminal-window .notebook.header {
+            .terminator-terminal-window .notebook.header,
+            .terminator-terminal-window notebook header {
                 background-color: @theme_bg_color; }
 
             .terminator-terminal-window .pane-separator {
@@ -417,7 +418,8 @@
         # Fix several themes that put a borders, corners, or backgrounds around
         # viewports, making the titlebar look bad.
         css += """
-            .terminator-terminal-window GtkViewport {
+            .terminator-terminal-window GtkViewport,
+            .terminator-terminal-window viewport {
                 border-width: 0px;
                 border-radius: 0px;
                 background-color: transparent; }
@@ -485,7 +487,8 @@
         css = ""
         if self.config['handle_size'] in xrange(0, 21):
             css += """
-                .terminator-terminal-window GtkPaned {
+                .terminator-terminal-window GtkPaned,
+                .terminator-terminal-window paned {
                     -GtkPaned-handle-size: %s; }
                 """ % self.config['handle_size']
         style_provider = Gtk.CssProvider()