overlay-scrollbar

Merge lp:~laney/overlay-scrollbar/blacklist-gsm into lp:overlay-scrollbar

  1. blacklist-gsm
  2. Merge into trunk
Proposed by Iain Lane
Status: Merged
Approved by: Lars Karlitski
Approved revision: 388
Merged at revision: 388
Proposed branch: lp:~laney/overlay-scrollbar/blacklist-gsm
Merge into: lp:overlay-scrollbar
Diff against target: 11 lines (+1/-0)
1 file modified
os/os-scrollbar.c (+1/-0)
To merge this branch: bzr merge lp:~laney/overlay-scrollbar/blacklist-gsm
Reviewer Review Type Date Requested Status
Lars Karlitski Approve
PS Jenkins bot (community) continuous-integration Approve
Ayatana Scrollbar Team Pending
Review via email: mp+248026@code.launchpad.net

Commit message

Don't use overlay-scrollbars in gnome-system-monitor, they cause it to have a transparent background.

Description of the change

g-s-m has a transparent background and we don't know why

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:388
http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-ci/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-vivid-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-vivid-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/overlay-scrollbar-vivid-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/overlay-scrollbar-ci/18/rebuild

review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Ha, that's certainly a way to do it. Thanks for looking into it!

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

I figure the threshold to fix these things properly is passed, given that we've spent time on this and this is the last cycle with o-s (*cough*).

Could you top approve?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2014-10-28 23:04:40 +0000
3+++ os/os-scrollbar.c 2015-01-29 17:04:10 +0000
4@@ -4072,6 +4072,7 @@
5 static const gchar *blacklist[] = {
6 "acroread", /* https://bugs.launchpad.net/ayatana-scrollbar/+bug/876218 */
7 "eclipse", /* https://bugs.launchpad.net/ayatana-scrollbar/+bug/769277 */
8+ "gnome-system-monitor", /* https://bugs.launchpad.net/overlay-scrollbar/+bug/1415964 */
9 "gnucash", /* https://bugs.launchpad.net/ayatana-scrollbar/+bug/770304 */
10 "gvim", /* https://bugs.launchpad.net/ayatana-scrollbar/+bug/847943 */
11 "lnotes", /* https://bugs.launchpad.net/ayatana-scrollbar/+bug/890986 */

Subscribers

People subscribed via source and target branches