Merge ~laney/libhybris/+git/libhybris:master into ~libhybris-maintainers/libhybris/+git/libhybris:master

Proposed by Iain Lane
Status: Merged
Approved by: Simon Fels
Approved revision: ce5da0538db19c09f1b923f2a7aa839694c0610e
Merged at revision: 0afe2ecc75a309a2121e44e620a49d899b458bbb
Proposed branch: ~laney/libhybris/+git/libhybris:master
Merge into: ~libhybris-maintainers/libhybris/+git/libhybris:master
Diff against target: 29 lines (+6/-3)
2 files modified
debian/changelog (+6/-0)
hybris/common/hooks.c (+0/-3)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Review via email: mp+302391@code.launchpad.net

Description of the change

libhybris (in git or in yakkety) fails to build like this since the gcc6 switch:

hooks.c: At top level:
hooks.c:2586:5: error: built-in function ‘__memcpy_chk’ must be directly called
     {"__memcpy_chk", __memcpy_chk},
     ^
hooks.c:2587:5: error: built-in function ‘__memset_chk’ must be directly called
     {"__memset_chk", __memset_chk},
     ^
hooks.c:2589:5: error: built-in function ‘__strncpy_chk’ must be directly called
     {"__strncpy_chk",__strncpy_chk},
     ^

This was always an error - just earlier GCC versions were buggy in not making it one.

My fix is to just remove these from the table; not sure if that's right.

I uploaded this to yakkety already.

By the way, the versioning in libhybris is weird. It's at ...ubuntu22 now - but I would have expected you to generate new upstream tarballs for most of these uploads. Also git here has its Debian releases incremented out of step with the archive (at least yakkety), which is unusual.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 223bc60..f9a4ca1 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+libhybris (0.1.0+git20151016+6d424c9-0ubuntu23) UNRELEASED; urgency=medium
7+
8+ * hooks:c: Don't pass builtin functions.
9+
10+ -- Iain Lane <iain.lane@canonical.com> Tue, 09 Aug 2016 11:40:54 +0100
11+
12 libhybris (0.1.0+git20151016+6d424c9-0ubuntu22) yakkety; urgency=medium
13
14 [ You-Sheng Yang ]
15diff --git a/hybris/common/hooks.c b/hybris/common/hooks.c
16index ce9972b..67a9b89 100644
17--- a/hybris/common/hooks.c
18+++ b/hybris/common/hooks.c
19@@ -2583,10 +2583,7 @@ static struct _hook hooks_mm[] = {
20 {"malloc_usable_size", _hybris_hook_malloc_usable_size},
21 {"posix_memalign", _hybris_hook_posix_memalign},
22 {"mprotect", _hybris_hook_mprotect},
23- {"__memcpy_chk", __memcpy_chk},
24- {"__memset_chk", __memset_chk},
25 {"__gnu_strerror_r",_hybris_hook__gnu_strerror_r},
26- {"__strncpy_chk",__strncpy_chk},
27 {"pthread_rwlockattr_getkind_np", _hybris_hook_pthread_rwlockattr_getkind_np},
28 {"pthread_rwlockattr_setkind_np", _hybris_hook_pthread_rwlockattr_setkind_np},
29 /* unistd.h */

Subscribers

People subscribed via source and target branches