Merge ~laney/libhybris/+git/libhybris:master into ~libhybris-maintainers/libhybris/+git/libhybris:master
Status: | Merged |
---|---|
Approved by: | Simon Fels |
Approved revision: | ce5da0538db19c09f1b923f2a7aa839694c0610e |
Merged at revision: | 0afe2ecc75a309a2121e44e620a49d899b458bbb |
Proposed branch: | ~laney/libhybris/+git/libhybris:master |
Merge into: | ~libhybris-maintainers/libhybris/+git/libhybris:master |
Diff against target: |
29 lines (+6/-3) 2 files modified
debian/changelog (+6/-0) hybris/common/hooks.c (+0/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Simon Fels | Approve | ||
Review via email: mp+302391@code.launchpad.net |
Description of the change
libhybris (in git or in yakkety) fails to build like this since the gcc6 switch:
hooks.c: At top level:
hooks.c:2586:5: error: built-in function ‘__memcpy_chk’ must be directly called
{"
^
hooks.c:2587:5: error: built-in function ‘__memset_chk’ must be directly called
{"
^
hooks.c:2589:5: error: built-in function ‘__strncpy_chk’ must be directly called
{"
^
This was always an error - just earlier GCC versions were buggy in not making it one.
My fix is to just remove these from the table; not sure if that's right.
I uploaded this to yakkety already.
By the way, the versioning in libhybris is weird. It's at ...ubuntu22 now - but I would have expected you to generate new upstream tarballs for most of these uploads. Also git here has its Debian releases incremented out of step with the archive (at least yakkety), which is unusual.
LGTM