Merge lp:~laney/libappindicator/cil-pcfile-arch-all into lp:libappindicator/13.10

Proposed by Iain Lane
Status: Rejected
Rejected by: Mathieu Trudel-Lapierre
Proposed branch: lp:~laney/libappindicator/cil-pcfile-arch-all
Merge into: lp:libappindicator/13.10
Diff against target: 53 lines (+28/-2)
3 files modified
bindings/mono/appindicator-sharp-0.1.pc.in (+1/-1)
debian/changelog (+26/-0)
debian/libappindicator0.1-cil-dev.install (+1/-1)
To merge this branch: bzr merge lp:~laney/libappindicator/cil-pcfile-arch-all
Reviewer Review Type Date Requested Status
Iain Lane Needs Resubmitting
Didier Roche-Tolomelli Needs Fixing
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+158086@code.launchpad.net

Commit message

Install appindicator-sharp's pcfile into /usr/share/pkgconfig as this is an arch:all package and library. Update the assemblydir variable in this pcfile to refer to the correct location for the library instead of an incorrect multiarch directory.

Description of the change

The pcfile for appindicator-sharp is broken in a couple of related ways

  * It's installed into a Multi-Arch directory in an arch:all package.
  * It references a multiarch libdir when the library isn't installed in one.

Fix both of these by properly using the unversioned locations.

(I haven't linked this to a bug and will set a commit message on the MP - if
that's not enough for the merger please let me know and I'll update d/changelog
manually.)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
262. By Iain Lane

Update changelog

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I think there was an issue with the merge, the extra changelog entries in a branch taht still needs to get merged...

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

Hmm, do I need to fix something?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

"* Automatic snapshot from revision 258"
-> you will obviously not remerged at rev 258, so you need to put a bootstrap commit to have daily release continuing in the UNRELEASED changelog.

review: Needs Fixing
Revision history for this message
Iain Lane (laney) wrote :

I don't know what that means. I just had branched from the 13.04 branch. I'll resubmit a new one vs. trunk.

Revision history for this message
Iain Lane (laney) wrote :

I couldn't use the resubmit feature (OOPS), so I did that manually.

  https://code.launchpad.net/~laney/libappindicator/cli-pcfile-arch-all-trunk/+merge/159166

review: Needs Resubmitting

Unmerged revisions

262. By Iain Lane

Update changelog

261. By Iain Lane

Set libdir for the cil pcfile to reflect that the library is installed in a non-MA directory

260. By Iain Lane

Install cil-dev pkgconfig file in /usr/share/pkgconfig - it's arch:all.

259. By PS Jenkins bot

Releasing 12.10.1daily13.04.09-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

258. By PS Jenkins bot

Releasing 12.10.1daily13.04.08-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

257. By Mathieu Trudel-Lapierre

debian/rules: reverse the order of dh_clean and dh_autoreconf_clean,
this fixes issues where clean removes files used by dh_autoreconf_clean.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bindings/mono/appindicator-sharp-0.1.pc.in'
2--- bindings/mono/appindicator-sharp-0.1.pc.in 2012-02-03 20:37:56 +0000
3+++ bindings/mono/appindicator-sharp-0.1.pc.in 2013-04-10 12:56:21 +0000
4@@ -1,7 +1,7 @@
5 prefix=@prefix@
6 exec_prefix=@exec_prefix@
7 libdir=@libdir@
8-assemblies_dir=${libdir}/cli/appindicator-sharp-0.1
9+assemblies_dir=${prefix}/lib/cli/appindicator-sharp-0.1
10
11 Name: appindicator-sharp
12 Description: application indicators for .NET
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2013-03-13 02:02:14 +0000
16+++ debian/changelog 2013-04-10 12:56:21 +0000
17@@ -1,3 +1,29 @@
18+libappindicator (12.10.1daily13.04.09-0ubuntu2) UNRELEASED; urgency=low
19+
20+ * Install appindicator-sharp's pcfile into /usr/share/pkgconfig as this is
21+ an arch:all package and library. Update the assemblydir variable in this
22+ pcfile to refer to the correct location for the library instead of an
23+ incorrect multiarch directory.
24+
25+ -- Iain Lane <iain.lane@canonical.com> Wed, 10 Apr 2013 12:57:58 +0100
26+
27+libappindicator (12.10.1daily13.04.09-0ubuntu1) raring; urgency=low
28+
29+ * Automatic snapshot from revision 258
30+
31+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 09 Apr 2013 02:02:28 +0000
32+
33+libappindicator (12.10.1daily13.04.08-0ubuntu1) raring; urgency=low
34+
35+ [ Mathieu Trudel-Lapierre ]
36+ * debian/rules: reverse the order of dh_clean and dh_autoreconf_clean,
37+ this fixes issues where clean removes files used by dh_autoreconf_clean.
38+
39+ [ Ubuntu daily release ]
40+ * Automatic snapshot from revision 257
41+
42+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 08 Apr 2013 02:02:59 +0000
43+
44 libappindicator (12.10.1daily13.03.13-0ubuntu1) raring; urgency=low
45
46 [ Sebastien Bacher ]
47
48=== modified file 'debian/libappindicator0.1-cil-dev.install'
49--- debian/libappindicator0.1-cil-dev.install 2012-11-27 02:18:17 +0000
50+++ debian/libappindicator0.1-cil-dev.install 2013-04-10 12:56:21 +0000
51@@ -1,1 +1,1 @@
52-usr/lib/*/pkgconfig/appindicator-sharp-0.1.pc
53+usr/lib/*/pkgconfig/appindicator-sharp-0.1.pc usr/share/pkgconfig

Subscribers

People subscribed via source and target branches