Merge lp:~laney/indicator-datetime/valid-day-of-month into lp:~indicator-applet-developers/indicator-datetime/trunk.13.10

[Iain Lane]

Use month '1' when constructing the 'begin' range to decide which appointments to display. glib started validating the arguments to g_date_time_new and it turns out that '0' isn't a valid day of the month.

Use month '1' when constructing the 'begin' range to decide which appointments to display.

glib started validating the arguments to g_date_time_new and it turns out that '0' isn't a valid day of the month. :-)

i-datetime-service crashes with new glib otherwise due to the function returning NULL and there being no checking for this.

[Sebastien Bacher (seb128)]

that makes sense ;-)

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:242
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/79/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-amd64-ci/33/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-armhf-ci/34/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-datetime-ci/79/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/22/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/1614/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-amd64-autolanding/16/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-armhf-autolanding/16/console

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

ok, CI got updated to not run the buggy hook, let's retry

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/23/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/1628
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-amd64-autolanding/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-saucy-armhf-autolanding/17/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'src/service.c'
--- src/service.c	2013-07-26 18:26:03 +0000
+++ src/service.c	2013-08-22 09:19:43 +0000
@@ -584,7 +584,7 @@
 
       calendar_date = get_calendar_date (self);
       g_date_time_get_ymd (calendar_date, &y, &m, &d);
-      begin = g_date_time_new_local (y, m, 0,
+      begin = g_date_time_new_local (y, m, 1,
                                      0, 0, 0);
       end = g_date_time_new_local (y, m, g_date_get_days_in_month(m,y),
                                    23, 59, 0);