Merge lp:~laney/gsettings-qt/add-symbols-file into lp:gsettings-qt

Proposed by Iain Lane
Status: Merged
Approved by: Iain Lane
Approved revision: 50
Merged at revision: 51
Proposed branch: lp:~laney/gsettings-qt/add-symbols-file
Merge into: lp:gsettings-qt
Diff against target: 62 lines (+48/-0)
2 files modified
debian/libgsettings-qt1.symbols (+45/-0)
debian/rules (+3/-0)
To merge this branch: bzr merge lp:~laney/gsettings-qt/add-symbols-file
Reviewer Review Type Date Requested Status
Robert Ancell (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Touch System Settings Pending
Review via email: mp+216072@code.launchpad.net

Commit message

Add a symbols file so that the qtdeclarative module (and other rdeps) get correctly versioned dependencies

Description of the change

https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4101/console

/var/local/autopilot/autopilot.log: /usr/bin/system-settings: symbol lookup error: /usr/lib/x86_64-linux-gnu/qt5/qml/GSettings.1.0/libGSettingsQmlPlugin.so: undefined symbol: _ZN10QGSettings17isSchemaInstalledERK10QByteArray

Something bad might have gone on here, but the deps shouldn't have been satisfiable. They were though, because qtdeclarative5-gsettings1.0 has only got an unversioned dependency on libgsettings-qt1 even though it uses symbols only present in a newer version.

Add a symbols file to ensure these get created properly.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
50. By Iain Lane

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/libgsettings-qt1.symbols'
2--- debian/libgsettings-qt1.symbols 1970-01-01 00:00:00 +0000
3+++ debian/libgsettings-qt1.symbols 2014-05-02 08:20:44 +0000
4@@ -0,0 +1,45 @@
5+libgsettings-qt.so.1 libgsettings-qt1 #MINVER#
6+ (c++)"qtify_name(char const*)@Base" 0.1+14.04.20140408
7+ (c++)"unqtify_name(QString const&)@Base" 0.1+14.04.20140408
8+ (c++)"qconf_types_unpack(_GVariant*, void*)@Base" 0.1+14.04.20140408
9+ (c++)"qconf_types_collect(_GVariantType const*, void const*)@Base" 0.1+14.04.20140408
10+ (c++)"qconf_types_convert(_GVariantType const*)@Base" 0.1+14.04.20140408
11+ (c++)"qconf_types_to_qvariant(_GVariant*)@Base" 0.1+14.04.20140408
12+ (c++)"qconf_types_collect_from_variant(_GVariantType const*, QVariant const&)@Base" 0.1+14.04.20140408
13+ (c++)"QByteArray::~QByteArray()@Base" 0.1+14.04.20140408
14+ (c++)"QByteArray::~QByteArray()@Base" 0.1+14.04.20140408
15+ (c++)"QGSettings::qt_metacall(QMetaObject::Call, int, void**)@Base" 0.1+14.04.20140408
16+ (c++)"QGSettings::qt_metacast(char const*)@Base" 0.1+14.04.20140408
17+ (c++)"QGSettings::staticMetaObject@Base" 0.1+14.04.20140408
18+ (c++)"QGSettings::isSchemaInstalled(QByteArray const&)@Base" 0.1+14.04.20140408
19+ (c++)"QGSettings::set(QString const&, QVariant const&)@Base" 0.1+14.04.20140408
20+ (c++)"QGSettings::reset(QString const&)@Base" 0.1+14.04.20140408
21+ (c++)"QGSettings::trySet(QString const&, QVariant const&)@Base" 0.1+14.04.20140408
22+ (c++)"QGSettings::changed(QString const&)@Base" 0.1+14.04.20140408
23+ (c++)"QGSettings::QGSettings(QByteArray const&, QByteArray const&, QObject*)@Base" 0.1+14.04.20140408
24+ (c++)"QGSettings::QGSettings(QByteArray const&, QByteArray const&, QObject*)@Base" 0.1+14.04.20140408
25+ (c++)"QGSettings::~QGSettings()@Base" 0.1+14.04.20140408
26+ (c++)"QGSettings::~QGSettings()@Base" 0.1+14.04.20140408
27+ (c++)"QGSettings::~QGSettings()@Base" 0.1+14.04.20140408
28+ (c++)"QGSettingsPrivate::settingChanged(_GSettings*, char const*, void*)@Base" 0.1+14.04.20140408
29+ (c++|optional=templinst)"QList<QString>::detach_helper_grow(int, int)@Base" 0.1+14.04.20140408
30+ (c++|optional=templinst)"QList<QString>::append(QString const&)@Base" 0.1+14.04.20140408
31+ (c++|optional=templinst)"QList<QString>::QList(QList<QString> const&)@Base" 0.1+14.04.20140408
32+ (c++|optional=templinst)"QList<QString>::QList(QList<QString> const&)@Base" 0.1+14.04.20140408
33+ (c++|optional=templinst)"QList<QString>::~QList()@Base" 0.1+14.04.20140408
34+ (c++|optional=templinst)"QList<QString>::~QList()@Base" 0.1+14.04.20140408
35+ (c++|optional=templinst)"QList<QVariant>::detach_helper_grow(int, int)@Base" 0.1+14.04.20140408
36+ (c++|optional=templinst)"QList<QVariant>::append(QVariant const&)@Base" 0.1+14.04.20140408
37+ (c++|optional=templinst)"QList<QVariant>::QList(QList<QVariant> const&)@Base" 0.1+14.04.20140408
38+ (c++|optional=templinst)"QList<QVariant>::QList(QList<QVariant> const&)@Base" 0.1+14.04.20140408
39+ (c++|optional=templinst)"QList<QVariant>::~QList()@Base" 0.1+14.04.20140408
40+ (c++|optional=templinst)"QList<QVariant>::~QList()@Base" 0.1+14.04.20140408
41+ (c++)"QString::~QString()@Base" 0.1+14.04.20140408
42+ (c++)"QString::~QString()@Base" 0.1+14.04.20140408
43+ (c++)"QGSettings::metaObject() const@Base" 0.1+14.04.20140408
44+ (c++)"QGSettings::get(QString const&) const@Base" 0.1+14.04.20140408
45+ (c++)"QGSettings::keys() const@Base" 0.1+14.04.20140408
46+ (c++)"QGSettings::choices(QString const&) const@Base" 0.1+14.04.20140408
47+ (c++)"typeinfo for QGSettings@Base" 0.1+14.04.20140408
48+ (c++)"typeinfo name for QGSettings@Base" 0.1+14.04.20140408
49+ (c++)"vtable for QGSettings@Base" 0.1+14.04.20140408
50
51=== modified file 'debian/rules'
52--- debian/rules 2013-06-25 16:54:35 +0000
53+++ debian/rules 2014-05-02 08:20:44 +0000
54@@ -12,5 +12,8 @@
55 override_dh_auto_test:
56 xvfb-run -a dh_auto_test
57
58+override_dh_makeshlibs:
59+ dh_makeshlibs -- -c4
60+
61 %:
62 dh $@

Subscribers

People subscribed via source and target branches

to all changes: