Merge lp:~laney/friends/tests-writable-home into lp:friends

Proposed by Iain Lane
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 244
Merged at revision: 244
Proposed branch: lp:~laney/friends/tests-writable-home
Merge into: lp:friends
Diff against target: 14 lines (+3/-1)
1 file modified
debian/rules (+3/-1)
To merge this branch: bzr merge lp:~laney/friends/tests-writable-home
Reviewer Review Type Date Requested Status
Robert Bruce Park Approve
Review via email: mp+195193@code.launchpad.net

Commit message

The testsuite expects $HOME to be writable, but you aren't guaranteed this. Create & set it while running the testsuite during package build.

Description of the change

The testsuite expects $HOME to be writable, but you aren't guaranteed this.

Make it ourselves in debian/rules when running the testsuite.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

I never was able to reproduce this, but if this works for you, I don't have any problems with it.

Thanks for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules'
2--- debian/rules 2013-03-14 20:25:42 +0000
3+++ debian/rules 2013-11-14 10:14:59 +0000
4@@ -25,7 +25,9 @@
5 dh_install --fail-missing
6
7 override_dh_auto_test:
8- dbus-test-runner -t make -p check -m 300
9+ mkdir $(CURDIR)/debian/tmp-home
10+ HOME=$(CURDIR)/debian/tmp-home dbus-test-runner -t make -p check -m 300
11+ rm -r $(CURDIR)/debian/tmp-home
12
13 %:
14 dh $@ --with python3,autoreconf

Subscribers

People subscribed via source and target branches

to all changes: