Merge lp:~laney/autopilot/legacy-psutil-children into lp:autopilot/legacy

Proposed by Iain Lane
Status: Needs review
Proposed branch: lp:~laney/autopilot/legacy-psutil-children
Merge into: lp:autopilot/legacy
Diff against target: 11 lines (+1/-1)
1 file modified
autopilot/introspection/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~laney/autopilot/legacy-psutil-children
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Autopilot Hackers Pending
Review via email: mp+283667@code.launchpad.net

Commit message

psutil.Process.get_children is removed, use children instead

Description of the change

Tests are failing because python-psutil removed its deprecated "get_children" function

  https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/s/shotwell/20160121_170215@/log.gz

...its replacement is "children"

sorry, I don't understand your branch scheme, hopefully this is right

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

uploading this to block tests, overwrite if you use CI train to publish, or reject/fix a different way/overwrite

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

500. By Iain Lane

psutil.Process.get_children is removed, use children instead

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/introspection/__init__.py'
2--- autopilot/introspection/__init__.py 2014-04-07 23:25:11 +0000
3+++ autopilot/introspection/__init__.py 2016-01-22 17:42:02 +0000
4@@ -434,7 +434,7 @@
5 def __call__(self, pid):
6 if self._cached_result is None:
7 self._cached_result = [
8- p.pid for p in psutil.Process(pid).get_children(recursive=True)
9+ p.pid for p in psutil.Process(pid).children(recursive=True)
10 ]
11 return self._cached_result
12

Subscribers

People subscribed via source and target branches

to all changes: