Merge lp:~laney/autopilot-qt/no-hardcode-xpathselect into lp:autopilot-qt

Proposed by Iain Lane on 2015-08-24
Status: Superseded
Proposed branch: lp:~laney/autopilot-qt/no-hardcode-xpathselect
Merge into: lp:autopilot-qt
Diff against target: 13 lines (+1/-2)
1 file modified
debian/control (+1/-2)
To merge this branch: bzr merge lp:~laney/autopilot-qt/no-hardcode-xpathselect
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2015-08-24
Autopilot Hackers 2015-08-24 Pending
Review via email: mp+268943@code.launchpad.net

This proposal has been superseded by a proposal from 2015-08-24.

Commit Message

Don't hardcode the xpathselect dependency - it should be auto detected.

Description of the Change

Don't hardcode the xpathselect dependency - it should be auto detected.

Note that I can't verify this because the tests fail

FAIL! : tst_Introspection::test_introspect(/) Compared values are not the same
   Actual (first_object.state.value(firstResultPropertyName)): QVariant(QVariantList,<value not representable as string>)
   Expected (firstResultPropertyValue) : QVariant(QVariantList,<value not representable as string>)
   Loc: [../../../tests/unittests/tst_introspection.cpp(265)]
FAIL! : tst_Introspection::test_introspect(//QWidget[id=6]) Compared values are not the same
   Actual (resultList.count()): 0
   Expected (resultCount) : 1
   Loc: [../../../tests/unittests/tst_introspection.cpp(259)]
FAIL! : tst_Introspection::test_introspect(//QPushButton[id=9]) Compared values are not the same
   Actual (resultList.count()): 0
   Expected (resultCount) : 1
   Loc: [../../../tests/unittests/tst_introspection.cpp(259)]

...please could you help me understand why and fix this?

Then branch off this branch and upload to silo 019.

To post a comment you must log in.
Iain Lane (laney) wrote :

If you try to fix this, please test against the xpathselect in silo 019 currently.

PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:93
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~laney/autopilot-qt/no-hardcode-xpathselect/+merge/268943/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/30/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-i386-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-qt-ci/30/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-08-19 23:59:15 +0000
3+++ debian/control 2015-08-24 17:00:54 +0000
4@@ -69,8 +69,7 @@
5 Package: qttestability-autopilot
6 Section: libs
7 Architecture: any
8-Depends: libxpathselect1.4,
9- python3-autopilot (>= 1.4),
10+Depends: python3-autopilot (>= 1.4),
11 autopilot-qt5 | autopilot-qt4
12 ${misc:Depends},
13 ${shlibs:Depends}

Subscribers

People subscribed via source and target branches

to all changes: