Merge ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.13.5-lunar into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Proposed by
Lucas Albuquerque Medeiros de Moura
Status: | Merged |
---|---|
Merged at revision: | ff475667b11dfef87ba26f7cd31a90b609b03b9c |
Proposed branch: | ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.13.5-lunar |
Merge into: | ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel |
Diff against target: |
65 lines (+12/-2) 4 files modified
debian/changelog (+8/-0) debian/ubuntu-advantage-tools.postinst (+1/-1) sru/release-27.13.5/test-no-esm-apps-duplicates.sh (+2/-0) uaclient/version.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Durigan Junior (community) | Approve | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+437106@code.launchpad.net |
To post a comment you must log in.
Thanks for the MP.
Minor nit regarding the SRU text: "Test Case" should now be "Test Plan", and "Regression Potential" should be "Where problems could occur". These are stylistic changes; the actual content looks good.
I found an issue in the d/changelog entry, and I'm leaving a question about something that caught my attention in the test script. Once everything is addressed I can sponsor it.
Thank you.