Merge ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.13.5-lunar into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel

Proposed by Lucas Albuquerque Medeiros de Moura
Status: Merged
Merged at revision: ff475667b11dfef87ba26f7cd31a90b609b03b9c
Proposed branch: ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.13.5-lunar
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Diff against target: 65 lines (+12/-2)
4 files modified
debian/changelog (+8/-0)
debian/ubuntu-advantage-tools.postinst (+1/-1)
sru/release-27.13.5/test-no-esm-apps-duplicates.sh (+2/-0)
uaclient/version.py (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Reporter Pending
Review via email: mp+437106@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP.

Minor nit regarding the SRU text: "Test Case" should now be "Test Plan", and "Regression Potential" should be "Where problems could occur". These are stylistic changes; the actual content looks good.

I found an issue in the d/changelog entry, and I'm leaving a question about something that caught my attention in the test script. Once everything is addressed I can sponsor it.

Thank you.

review: Needs Fixing
Revision history for this message
Renan Rodrigo (renanrodrigo) wrote :

Thanks for the review, sergiodj. We'll fix the changelog entry.

Revision history for this message
Sergio Durigan Junior (sergiodj) :
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks.

Uploaded:

$ dput ubuntu-advantage-tools_27.13.5~23.04.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_27.13.5~23.04.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_27.13.5~23.04.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_27.13.5~23.04.1.dsc: done.
  Uploading ubuntu-advantage-tools_27.13.5~23.04.1.tar.xz: done.
  Uploading ubuntu-advantage-tools_27.13.5~23.04.1_source.buildinfo: done.
  Uploading ubuntu-advantage-tools_27.13.5~23.04.1_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index ca7c2b3..d3ea6b6 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+ubuntu-advantage-tools (27.13.5~23.04.1) lunar; urgency=medium
7+
8+ * d/ubuntu-advantage-tools.postinst:
9+ - fix version for cleaning the esm-apps stale unauthenticated files
10+ (LP: #2006765)
11+
12+ -- Renan Rodrigo <renanrodrigo@canonical.com> Thu, 09 Feb 2023 14:20:47 -0300
13+
14 ubuntu-advantage-tools (27.13.4~23.04.1) lunar; urgency=medium
15
16 * d/ubuntu-advantage-tools.postinst:
17diff --git a/debian/ubuntu-advantage-tools.postinst b/debian/ubuntu-advantage-tools.postinst
18index 8685602..5551478 100644
19--- a/debian/ubuntu-advantage-tools.postinst
20+++ b/debian/ubuntu-advantage-tools.postinst
21@@ -378,7 +378,7 @@ case "$1" in
22 fi
23 fi
24
25- if dpkg --compare-versions "$PREVIOUS_PKG_VER" lt "27.13.3~"; then
26+ if dpkg --compare-versions "$PREVIOUS_PKG_VER" lt "27.13.5~"; then
27 # esm-apps unauthenticated ESM should not be in any release
28 esm_apps_cleanup
29 fi
30diff --git a/sru/release-27.13.4/test-no-esm-apps-duplicates-attached.sh b/sru/release-27.13.5/test-no-esm-apps-duplicates-attached.sh
31similarity index 100%
32rename from sru/release-27.13.4/test-no-esm-apps-duplicates-attached.sh
33rename to sru/release-27.13.5/test-no-esm-apps-duplicates-attached.sh
34diff --git a/sru/release-27.13.4/test-no-esm-apps-duplicates.sh b/sru/release-27.13.5/test-no-esm-apps-duplicates.sh
35similarity index 98%
36rename from sru/release-27.13.4/test-no-esm-apps-duplicates.sh
37rename to sru/release-27.13.5/test-no-esm-apps-duplicates.sh
38index 2d2e2ba..2a7282c 100755
39--- a/sru/release-27.13.4/test-no-esm-apps-duplicates.sh
40+++ b/sru/release-27.13.5/test-no-esm-apps-duplicates.sh
41@@ -74,9 +74,11 @@ echo -e "###########################################\n"
42 # ----------------------------------------------------------------
43 if [ $install_from == 'staging' ]; then
44 lxc exec $name -- sudo add-apt-repository ppa:ua-client/staging -y > /dev/null
45+ lxc exec $name -- apt-get update > /dev/null
46 lxc exec $name -- apt-get install ubuntu-advantage-tools -y > /dev/null
47 elif [ $install_from == 'proposed' ]; then
48 lxc exec $name -- sh -c "echo \"deb http://archive.ubuntu.com/ubuntu $series-proposed main\" | tee /etc/apt/sources.list.d/proposed.list"
49+ lxc exec $name -- apt-get update > /dev/null
50 lxc exec $name -- apt-get install ubuntu-advantage-tools -y > /dev/null
51 else
52 lxc file push $install_from $name/new-ua.deb
53diff --git a/uaclient/version.py b/uaclient/version.py
54index 081c3b6..011d672 100644
55--- a/uaclient/version.py
56+++ b/uaclient/version.py
57@@ -15,7 +15,7 @@ from uaclient.defaults import CANDIDATE_CACHE_PATH, UAC_RUN_PATH
58 from uaclient.exceptions import ProcessExecutionError
59 from uaclient.system import subp
60
61-__VERSION__ = "27.13.4"
62+__VERSION__ = "27.13.5"
63 PACKAGED_VERSION = "@@PACKAGED_VERSION@@"
64
65 CANDIDATE_REGEX = r"Candidate: (?P<candidate>.*?)\n"

Subscribers

People subscribed via source and target branches

to status/vote changes: