Merge ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.4.2-jammy into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel

Proposed by Lucas Albuquerque Medeiros de Moura
Status: Merged
Merged at revision: edd0cb9da66cc40fe9cbb36619a005a6868f335b
Proposed branch: ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-27.4.2-jammy
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Diff against target: 33 lines (+11/-3)
2 files modified
debian/changelog (+8/-0)
debian/ubuntu-advantage-tools.postinst (+3/-3)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+412296@code.launchpad.net

Description of the change

This is the proposed release for 27.4.2
The main goal of this release is to fix a postinst issue that happens for unattached users with machine with architecture that are different than i386 and amd64. More details about the issue we are solving can be found here:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1951705

Let us know if there is anything that we need to update on this release

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, guys.

Uploaded:

$ dput ubuntu-advantage-tools_27.4.2~22.04.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_27.4.2~22.04.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_27.4.2~22.04.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_27.4.2~22.04.1.dsc: done.
  Uploading ubuntu-advantage-tools_27.4.2~22.04.1.tar.xz: done.
  Uploading ubuntu-advantage-tools_27.4.2~22.04.1_source.buildinfo: done.
  Uploading ubuntu-advantage-tools_27.4.2~22.04.1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index bcb6bd7..9779f56 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+ubuntu-advantage-tools (27.4.2~22.04.1) jammy; urgency=medium
7+
8+ * d/tools.postinst:
9+ - Fix check_service_is_enabled function when the machine is
10+ unattached (LP: #1951705)
11+
12+ -- Lucas Moura <lucas.moura@canonical.com> Tue, 23 Nov 2021 09:20:56 -0300
13+
14 ubuntu-advantage-tools (27.4.1~22.04.1) jammy; urgency=medium
15
16 * jobs: do not run the status job for unattached users
17diff --git a/debian/ubuntu-advantage-tools.postinst b/debian/ubuntu-advantage-tools.postinst
18index 09f7bd3..8ba7c64 100644
19--- a/debian/ubuntu-advantage-tools.postinst
20+++ b/debian/ubuntu-advantage-tools.postinst
21@@ -145,9 +145,9 @@ from uaclient.config import UAConfig
22 cfg = UAConfig()
23 status = cfg.read_cache('status-cache')
24 if status:
25- for service in status['services']:
26- if service['name'] == '${service_name}':
27- print(service['status'])
28+ for service in status.get('services', []):
29+ if service.get('name', '') == '${service_name}':
30+ print(service.get('status', ''))
31 ")
32 if [ "${_RET}" = "enabled" ]; then
33 return 0

Subscribers

People subscribed via source and target branches

to status/vote changes: