Merge lp:~lamont/maas/bug-1614584 into lp:~maas-committers/maas/trunk

[LaMont Jones]

Handle the case where gethostname() returns an FQDN.

Handle the case where gethostname() returns an FQDN.

[Blake Rouse (blake-rouse)]

Looks good.

review: Approve

[lp:~lamont/maas/bug-1614584]

5591. By LaMont Jones on 2016-12-07

Driveby: fix TestStaticIPAddressManagerMapping.test_get_hostname_ip_mapping_returns_fqdn_and_other.

5592. By LaMont Jones on 2016-12-07

Strip any domain from the remaining uses of gethostname().

=== modified file 'src/maasserver/models/node.py'
--- src/maasserver/models/node.py	2016-12-02 17:41:31 +0000
+++ src/maasserver/models/node.py	2016-12-07 12:47:26 +0000
@@ -743,7 +743,19 @@
         regiond has run on it. Create a region controller only; it can be
         upgraded to a region+rack controller later if necessary.
         """
-        return self.create(owner=get_worker_user(), hostname=gethostname())
+        hostname = gethostname()
+        # Bug#1614584: it is possible that gethostname() reurns the FQDN.
+        # Split it up, and get the appropriate domain.  If we wind up creating
+        # one for it, we are not authoritative.
+        # Just in case the default domain has not been created, let's create it
+        # here, even if we subsequently overwrite it inside the if statement.
+        domain = Domain.objects.get_default_domain()
+        if hostname.find('.') > 0:
+            hostname, domainname = hostname.split('.', 1)
+            (domain, _) = Domain.objects.get_or_create(
+                name=domainname, defaults={'authoritative': False})
+        return self.create(
+            owner=get_worker_user(), hostname=hostname, domain=domain)
 
 
 def get_default_domain():

=== modified file 'src/maasserver/models/tests/test_node.py'
--- src/maasserver/models/tests/test_node.py	2016-12-02 17:41:31 +0000
+++ src/maasserver/models/tests/test_node.py	2016-12-07 12:47:26 +0000
@@ -622,7 +622,12 @@
         super().setUp()
         # Patch out gethostname and get_mac_addresses.
         self.patch_autospec(node_module, "gethostname")
-        node_module.gethostname.return_value = factory.make_name("host")
+        hostname = factory.make_name('host')
+        # Bug#1614584: make sure that we handle the case where gethostname()
+        # returns an FQDN, instead of a domainless hostname.
+        if factory.pick_bool():
+            hostname += ".%s" % factory.make_name('domain')
+        node_module.gethostname.return_value = hostname
         self.patch_autospec(node_module, "get_mac_addresses")
         node_module.get_mac_addresses.return_value = []
 

=== modified file 'src/maasserver/models/tests/test_staticipaddress.py'
--- src/maasserver/models/tests/test_staticipaddress.py	2016-11-23 15:05:45 +0000
+++ src/maasserver/models/tests/test_staticipaddress.py	2016-12-07 12:47:26 +0000
@@ -424,20 +424,21 @@
             alloc_type=IPADDRESS_TYPE.STICKY,
             ip=factory.pick_ip_in_Subnet(subnet),
             subnet=subnet, interface=boot_interface)
-        ifaces = node.interface_set.exclude(interface=boot_interface)
+        iface2 = node.interface_set.exclude(id=boot_interface.id).first()
         sip2 = factory.make_StaticIPAddress(
             alloc_type=IPADDRESS_TYPE.STICKY,
             ip=factory.pick_ip_in_Subnet(subnet),
-            subnet=subnet, interface=ifaces[0])
+            subnet=subnet, interface=iface2)
         mapping = StaticIPAddress.objects.get_hostname_ip_mapping(subnet)
-        self.assertEqual({
+        expected = {
             full_hostname:
                 HostnameIPMapping(
                     node.system_id, 30, {staticip.ip}, node.node_type),
-            "%s.%s" % (ifaces[0].name, full_hostname):
+            "%s.%s" % (iface2.name, full_hostname):
                 HostnameIPMapping(
                     node.system_id, 30, {sip2.ip}, node.node_type),
-            }, mapping)
+        }
+        self.assertEqual(expected, mapping)
 
     def make_mapping(self, node, raw_ttl=False):
         if raw_ttl or node.address_ttl is not None: