Merge lp:~lamont/maas/bug-1553176-1.9-packaging into lp:~maas-maintainers/maas/packaging-1.9

Proposed by LaMont Jones on 2017-02-03
Status: Merged
Approved by: LaMont Jones on 2017-02-04
Approved revision: 440
Merged at revision: 439
Proposed branch: lp:~lamont/maas/bug-1553176-1.9-packaging
Merge into: lp:~maas-maintainers/maas/packaging-1.9
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~lamont/maas/bug-1553176-1.9-packaging
Reviewer Review Type Date Requested Status
Mike Pontillo (community) 2017-02-03 Approve on 2017-02-04
Review via email: mp+316385@code.launchpad.net

Commit message

Recommend a version of bind9 that has the fix for more-granular time checking.

Description of the change

With the change in https://code.launchpad.net/~lamont/maas/bug-1553176-1.9/+merge/316384 we want (Recommend) the version of bind9 in trusty that has that piece of the fix.

To post a comment you must log in.
Mike Pontillo (mpontillo) wrote :

Looks fine, though I can't say I understand why the ~ is needed on the end of the version string; care to enlighten me?

Strictly speaking, should this be something like:

Depends: bind9, ...
Recommends: bind9 (>= 1:9.9.5.dfsg-3ubuntu0.12~), ...

Or is repeating yourself not allowed?

review: Approve
LaMont Jones (lamont) wrote :

the depends/recommends: version is the best way to go (we're more broken without the maas fix than with it, even if you don't have the new bind9.)

The ~ is there for backport support, in case we were crazy and decided to backport 1.9 to precise. (Which is to say, pedantry calls for it, but in practice the ~ won't ever actually be strictly necessary for this particular case.)

440. By LaMont Jones on 2017-02-04

Depend: bind9, and recommend the updated version.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-03-01 19:42:41 +0000
3+++ debian/control 2017-02-04 02:44:26 +0000
4@@ -209,6 +209,7 @@
5 Depends: bind9,
6 maas-region-controller-min (= ${binary:Version}),
7 ${misc:Depends}
8+Recommends: bind9 (>= 1:9.9.5.dfsg-3ubuntu0.12~)
9 Conflicts: dnsmasq
10 Breaks: maas-dhcp (<= 0.1+bzr777+dfsg-0ubuntu1)
11 Replaces: maas-dhcp (<= 0.1+bzr777+dfsg-0ubuntu1)

Subscribers

People subscribed via source and target branches

to all changes: