Merge lp:~lamont/maas/bug-1553176-1.9-packaging into lp:~maas-maintainers/maas/packaging-1.9

[LaMont Jones]

Recommend a version of bind9 that has the fix for more-granular time checking.

With the change in https://code.launchpad.net/~lamont/maas/bug-1553176-1.9/+merge/316384 we want (Recommend) the version of bind9 in trusty that has that piece of the fix.

[Mike Pontillo (mpontillo)]

Looks fine, though I can't say I understand why the ~ is needed on the end of the version string; care to enlighten me?

Strictly speaking, should this be something like:

Depends: bind9, ...
Recommends: bind9 (>= 1:9.9.5.dfsg-3ubuntu0.12~), ...

Or is repeating yourself not allowed?

review: Approve

[LaMont Jones (lamont)]

the depends/recommends: version is the best way to go (we're more broken without the maas fix than with it, even if you don't have the new bind9.)

The ~ is there for backport support, in case we were crazy and decided to backport 1.9 to precise. (Which is to say, pedantry calls for it, but in practice the ~ won't ever actually be strictly necessary for this particular case.)

[lp:~lamont/maas/bug-1553176-1.9-packaging]

440. By LaMont Jones on 2017-02-04

Depend: bind9, and recommend the updated version.

=== modified file 'debian/control'
--- debian/control	2016-03-01 19:42:41 +0000
+++ debian/control	2017-02-04 02:44:26 +0000
@@ -209,6 +209,7 @@
 Depends: bind9,
  maas-region-controller-min (= ${binary:Version}),
  ${misc:Depends}
+Recommends: bind9 (>= 1:9.9.5.dfsg-3ubuntu0.12~)
 Conflicts: dnsmasq
 Breaks: maas-dhcp (<= 0.1+bzr777+dfsg-0ubuntu1)
 Replaces: maas-dhcp (<= 0.1+bzr777+dfsg-0ubuntu1)