Launchpad itself

Merge lp:~lamont/launchpad/bug-634859 into lp:launchpad

  1. bug-634859
  2. Merge into devel
Proposed by LaMont Jones
Status: Merged
Merged at revision: 11537
Proposed branch: lp:~lamont/launchpad/bug-634859
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/buildmaster/interfaces/builder.py (+1/-1)
To merge this branch: bzr merge lp:~lamont/launchpad/bug-634859
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Brad Crittenden (community) code Approve
Review via email: mp+35091@code.launchpad.net

Commit message

Change the UI name of builder.active from "Active" to "Present Publicly" to reduce confusion about its meaning.

Description of the change

Change the UI name of builder.active to reduce confusion about its meaning.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) :
review: Approve (code)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Brad is a little fast off the blocks there, I'll fix the test failure that this branch introduces and then land it :)

review: Approve
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for catching the test failure Julian. I ran the buildmaster test suite but not soyuz.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Monday 13 September 2010 12:51:48 you wrote:
> Thanks for catching the test failure Julian. I ran the buildmaster test
> suite but not soyuz.

FTR, buildmaster doesn't have any UI so stuff that changes titles/descriptions
etc will always need the soyuz stories running.

Cheers.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/buildmaster/interfaces/builder.py'
2--- lib/lp/buildmaster/interfaces/builder.py 2010-08-25 16:25:02 +0000
3+++ lib/lp/buildmaster/interfaces/builder.py 2010-09-10 12:26:01 +0000
4@@ -147,7 +147,7 @@
5 'buildd-slave, e.g.: foobar-host.ppa'))
6
7 active = Bool(
8- title=_('Active'), required=True, default=True,
9+ title=_('Publicly Visible'), required=True, default=True,
10 description=_('Whether or not to present the builder publicly.'))
11
12 slave = Attribute("xmlrpclib.Server instance corresponding to builder.")