Merge lp:~lains/cable/cable into lp:cable

Proposed by Lains
Status: Merged
Merged at revision: 101
Proposed branch: lp:~lains/cable/cable
Merge into: lp:cable
Diff against target: 12 lines (+1/-1)
1 file modified
src/Widgets/Welcome.vala (+1/-1)
To merge this branch: bzr merge lp:~lains/cable/cable
Reviewer Review Type Date Requested Status
Julien Spautz Needs Resubmitting
Review via email: mp+176127@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Julien Spautz (julien-spautz) wrote :

"Connect to IRC" is correct, but "Channel" should be "channel".

As Dan said: The first line should be Title Case and not contain punctuation. The second line should be sentence case and contain punctuation.

Revision history for this message
Julien Spautz (julien-spautz) :
review: Needs Fixing
lp:~lains/cable/cable updated
100. By Lains

Making the second line sentence case.

Revision history for this message
Lains (lains) wrote :

Fixed now.

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Again, it should be "Connect to IRC", not "Connect To IRC". "to" remains lower case. Sorry if I wasn't clear about that.

review: Needs Resubmitting
Revision history for this message
Lains (lains) wrote :

"As Dan said: The first line should be Title Case and not contain punctuation."

Connect To IRC would be right then, but I'll resubmit it anyways.

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Rules According to The Chicago Manual of Style:

· Lowercase of all articles, coordinate conjunctions (and, or, nor), and *prepositions* regardless of length, when they are other than the first or last word.

"to" is a preposition, so lowercase

source: http://suite101.com/article/how-to-write-in-title-case-a73866

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/Welcome.vala'
2--- src/Widgets/Welcome.vala 2013-07-04 01:34:38 +0000
3+++ src/Widgets/Welcome.vala 2013-07-22 15:07:24 +0000
4@@ -27,7 +27,7 @@
5 Gtk.ComboBoxText id_entry;
6
7 public Welcome () {
8- base (_("Connect to IRC"), _("Select a Channel to join and begin to talk."));
9+ base (_("Connect To IRC"), _("Select a channel to join and begin to talk."));
10
11 var grid = new Gtk.Grid ();
12 grid.margin = 12;

Subscribers

People subscribed via source and target branches

to all changes: