Merge lp:~lains/appcenter/appcenter into lp:~elementary-apps/appcenter/appcenter

[Lains]

Use the same icon for everything related to AppCenter

[Felipe Escoto (philip.scott)]

We should probably split this into two separate commits.

I'm file with the icon change, but it's currently too late in the cycle to change strings since the string change would require new translations for it

review: Needs Fixing (split commits)

[Lains (lains)]

I can fix the translations by hand, is it OK to do this?

[Felipe Escoto (philip.scott)]

English wouldn't be a problem, we would need translations for the rest of the languages ;)

[Lains (lains)]

I see. I'll revert this branch so it only fixes the icons bug when I get home. ;)

[Lains (lains)]

Reverted, and ready to merge! ;P

[lp:~lains/appcenter/appcenter]

284. By Lains <email address hidden> on 2016-08-28

Change notification icons to match branding

=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-08-23 14:35:57 +0000
+++ src/Core/Client.vala	2016-08-28 20:16:28 +0000
@@ -347,7 +347,7 @@
                 string body = ngettext ("%u update is available for your system", "%u updates are available for your system", updates_number).printf (updates_number);
                 var notification = new Notification (title);
                 notification.set_body (body);
-                notification.set_icon (new ThemedIcon ("software-update-available"));
+                notification.set_icon (new ThemedIcon ("system-software-install"));
                 notification.set_default_action ("app.open-application");
                 Application.get_default ().send_notification ("updates", notification);
             } else {

=== modified file 'src/MainWindow.vala'
--- src/MainWindow.vala	2016-08-20 16:51:58 +0000
+++ src/MainWindow.vala	2016-08-28 20:16:28 +0000
@@ -85,7 +85,7 @@
     }
 
     construct {
-        icon_name = "system-software-installer";
+        icon_name = "system-software-install";
         title = _("AppCenter");
         window_position = Gtk.WindowPosition.CENTER;