Merge lp:~lag/linaro-image-tools/lt-ux500-support into lp:linaro-image-tools/11.11

Proposed by Lee Jones
Status: Merged
Merged at revision: 308
Proposed branch: lp:~lag/linaro-image-tools/lt-ux500-support
Merge into: lp:linaro-image-tools/11.11
Diff against target: 12 lines (+1/-1)
1 file modified
linaro_media_create/boards.py (+1/-1)
To merge this branch: bzr merge lp:~lag/linaro-image-tools/lt-ux500-support
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Needs Fixing
Review via email: mp+53970@code.launchpad.net

Description of the change

Include support for the new u8500 hardware pack

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

Could you explain why the kernel is suffixed u8500? Are there going to be both ux500 and u8500 kernels?

Is one a Landing Team kernel? Should it be lt-u8500?

Revision history for this message
Lee Jones (lag) wrote :

On 18/03/11 13:52, Loïc Minier wrote:
> Could you explain why the kernel is suffixed u8500? Are there going to be both ux500 and u8500 kernels?

Because this kernel does not support the u5500.

> Is one a Landing Team kernel? Should it be lt-u8500?

There is only one kernel at present, which is the BSP one.

Revision history for this message
Loïc Minier (lool) wrote :

So the current config never worked?

Will you eventually support u5500?

Revision history for this message
Lee Jones (lag) wrote :

On 18/03/11 14:33, Loïc Minier wrote:
> So the current config never worked?

Not for the new hwpack, no.

The old hwpack still works as well as it always did.

> Will you eventually support u5500?

Not that I'm aware of.

Revision history for this message
Guilherme Salgado (salgado) wrote :

Lee, do you foresee any issues if we are a bit more conservative and use 'u?500' as the suffix instead of 'u*500'?

Revision history for this message
Lee Jones (lag) wrote :

On 28/03/11 14:39, Guilherme Salgado wrote:
> Lee, do you foresee any issues if we are a bit more conservative and use 'u?500' as the suffix instead of 'u*500'?

What's the difference?

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Mon, 2011-03-28 at 13:43 +0000, Lee Jones wrote:
> On 28/03/11 14:39, Guilherme Salgado wrote:
> > Lee, do you foresee any issues if we are a bit more conservative and use 'u?500' as the suffix instead of 'u*500'?
>
> What's the difference?

'*' is greedy: it will match any number of characters whereas '?' will
match only one.

Revision history for this message
Lee Jones (lag) wrote :

On 28/03/11 14:51, Guilherme Salgado wrote:
> On Mon, 2011-03-28 at 13:43 +0000, Lee Jones wrote:
>> On 28/03/11 14:39, Guilherme Salgado wrote:
>>> Lee, do you foresee any issues if we are a bit more conservative and use 'u?500' as the suffix instead of 'u*500'?
>>
>> What's the difference?
>
> '*' is greedy: it will match any number of characters whereas '?' will
> match only one.

'?' is perfect.

Revision history for this message
Guilherme Salgado (salgado) wrote :

I see we currently have only one hwpack with the BSP kernel but if there are plans to have a non-BSP kernel then we should take advantage of the support for multiple suffixes that is being proposed on bug 744857. Otherwise just changing 'u*500' to 'u?500' should be fine.

review: Needs Fixing
Revision history for this message
Lee Jones (lag) wrote :

I guess either would work.

There are already two hwpacks by the way, a BSP one and a LT one.

Revision history for this message
Guilherme Salgado (salgado) wrote :

But do they share the same suffix? 'cause if they don't then we'll need
to use a list of suffixes.

Revision history for this message
Loïc Minier (lool) wrote :

I've merged this with the change Guilherme proposed and added a note in https://code.launchpad.net/~mabac/linaro-image-tools/bug-744857/+merge/55492 that we should use kernel_flavors instead of a regexp.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_media_create/boards.py'
2--- linaro_media_create/boards.py 2011-03-10 23:28:21 +0000
3+++ linaro_media_create/boards.py 2011-03-18 10:36:54 +0000
4@@ -395,7 +395,7 @@
5 kernel_addr = '0x00100000'
6 initrd_addr = '0x08000000'
7 load_addr = '0x00008000'
8- kernel_suffix = 'ux500'
9+ kernel_suffix = 'u*500'
10 boot_script = 'flash.scr'
11 extra_boot_args_options = (
12 'earlyprintk rootdelay=1 fixrtc nocompcache '

Subscribers

People subscribed via source and target branches