Merge lp:~lachlan-mulcahy/percona-xtrabackup/1.6-bug860133 into lp:percona-xtrabackup/1.6

Proposed by Lachlan Mulcahy
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 301
Proposed branch: lp:~lachlan-mulcahy/percona-xtrabackup/1.6-bug860133
Merge into: lp:percona-xtrabackup/1.6
Diff against target: 24 lines (+3/-3)
1 file modified
innobackupex (+3/-3)
To merge this branch: bzr merge lp:~lachlan-mulcahy/percona-xtrabackup/1.6-bug860133
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+77068@code.launchpad.net

Commit message

Fixed bug 860133 - Simply skipped the section of code that is irrelevant when --incremental-lsn is specified.

Description of the change

  Fixed bug 860133

  innobackupex throws errors when using --incremental and --incremental-lsn together when it tries to ls contents of a dir that it plans to create later anyway. The ls is only required if incremental-lsn isn't specified.

  Simply skipped the section of code that is irrelevant when --incremental-lsn is specified.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2011-09-21 09:00:00 +0000
3+++ innobackupex 2011-09-26 23:27:26 +0000
4@@ -770,9 +770,9 @@
5 if ($option_incremental) {
6 if($option_incremental_lsn) {
7 $options = $options . " --incremental-lsn='$option_incremental_lsn'";
8- } else {
9+ } else {
10 $options = $options . " --incremental-basedir='$incremental_basedir'";
11- }
12+ }
13 }
14
15 if ($option_tables_file) {
16@@ -1658,7 +1658,7 @@
17 if (!$option_apply_log && !$option_copy_back) {
18 # we are making a backup, get backup root directory
19 $backup_root = $ARGV[0];
20- if ($option_incremental) {
21+ if ($option_incremental && !$option_incremental_lsn) {
22 my @dirs = `ls -1 -t $backup_root`;
23 my $inc_dir = $dirs[0];
24 chomp($inc_dir);

Subscribers

People subscribed via source and target branches