Merge lp:~l3on/ubuntu/precise/rawstudio/fix-ftbfs into lp:ubuntu/precise/rawstudio

Proposed by Leo Iannacone
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~l3on/ubuntu/precise/rawstudio/fix-ftbfs
Merge into: lp:ubuntu/precise/rawstudio
Diff against target: 60 lines (+29/-1)
4 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/add-gthread-reference.patch (+20/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~l3on/ubuntu/precise/rawstudio/fix-ftbfs
Reviewer Review Type Date Requested Status
Benjamin Kerensa (community) Disapprove
Ubuntu branches Pending
Review via email: mp+94701@code.launchpad.net

Description of the change

Added a check on gthread-2.0. Patch taken from upstream.

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Sorry. It seems like Daniel Chen already fixed this bug. I'm going to mark this merge proposal as rejected. https://bugs.launchpad.net/ubuntu/+source/rawstudio/+bug/935406/comments/1

Good work on the solution nonetheless.

Revision history for this message
Benjamin Kerensa (bkerensa) :
review: Disapprove

Unmerged revisions

27. By Leo Iannacone

Linking gthread-2.0 during build (LP: #935406).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-10-30 11:58:38 +0000
3+++ debian/changelog 2012-02-27 00:32:18 +0000
4@@ -1,3 +1,9 @@
5+rawstudio (2.0-1ubuntu1) precise; urgency=low
6+
7+ * Linking gthread-2.0 during build (LP: #935406).
8+
9+ -- Leo Iannacone <l3on@ubuntu.com> Mon, 27 Feb 2012 00:44:13 +0100
10+
11 rawstudio (2.0-1build1) precise; urgency=low
12
13 * Rebuild for libexiv2-11.
14
15=== modified file 'debian/control'
16--- debian/control 2011-07-28 17:36:32 +0000
17+++ debian/control 2012-02-27 00:32:18 +0000
18@@ -1,7 +1,8 @@
19 Source: rawstudio
20 Section: graphics
21 Priority: optional
22-Maintainer: Debian PhotoTools Maintainers <pkg-phototools-devel@lists.alioth.debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Debian PhotoTools Maintainers <pkg-phototools-devel@lists.alioth.debian.org>
25 Uploaders: Bernd Zeimetz <bzed@debian.org>
26 Build-Depends: debhelper (>= 7.2.14), autotools-dev (>= 20100122.1), dh-autoreconf, libdbus-1-dev, libexiv2-dev, libgconf2-dev, libgtk2.0-dev, liblcms1-dev, libjpeg8-dev, libtiff4-dev, libxml2-dev, quilt (>= 0.46-7), libfftw3-dev, liblensfun-dev, libcurl4-gnutls-dev, libflickcurl-dev, libsqlite3-dev, libgphoto2-2-dev
27 Standards-Version: 3.8.3
28
29=== added file 'debian/patches/add-gthread-reference.patch'
30--- debian/patches/add-gthread-reference.patch 1970-01-01 00:00:00 +0000
31+++ debian/patches/add-gthread-reference.patch 2012-02-27 00:32:18 +0000
32@@ -0,0 +1,20 @@
33+Description: Add -lgthread-2.0 during build. Patch stolen from upstream.
34+Author: Leo Iannacone <l3on@ubuntu.com>
35+Bug-Ubuntu: https://bugs.launchpad.net/bugs/935406
36+Forwarded: no
37+
38+---
39+ configure.in | 2 +-
40+ 1 file changed, 1 insertion(+), 1 deletion(-)
41+
42+--- rawstudio.orig/configure.in
43++++ rawstudio/configure.in
44+@@ -83,7 +83,7 @@ AC_CHECK_LIB(tiff, TIFFOpen, tiff_ok=yes
45+ fi
46+ AC_SUBST(LIBTIFF)
47+
48+-pkg_modules="gtk+-2.0 >= 2.8.0 libxml-2.0 >= 2.4 gconf-2.0 >= 2.0 lcms dbus-1 exiv2 fftw3f lensfun libcurl flickcurl sqlite3 libgphoto2 x11"
49++pkg_modules="gtk+-2.0 >= 2.8.0 libxml-2.0 >= 2.4 gconf-2.0 >= 2.0 lcms dbus-1 exiv2 fftw3f lensfun libcurl flickcurl sqlite3 libgphoto2 x11 gthread-2.0"
50+ PKG_CHECK_MODULES(PACKAGE, [$pkg_modules])
51+ AC_SUBST(PACKAGE_CFLAGS)
52+ AC_SUBST(PACKAGE_LIBS)
53
54=== modified file 'debian/patches/series'
55--- debian/patches/series 2011-07-28 17:36:32 +0000
56+++ debian/patches/series 2012-02-27 00:32:18 +0000
57@@ -1,2 +1,3 @@
58 0001-Remove-libssl-requirement-from-configure.patch
59 0002-Fix-the-plugin-directory-path.patch
60+add-gthread-reference.patch

Subscribers

People subscribed via source and target branches

to all changes: