Merge lp:~l3on/ubuntu/precise/pino/fix-ftbfs into lp:ubuntu/precise/pino

Proposed by Leo Iannacone
Status: Merged
Merge reported by: Andreas Moog
Merged at revision: not available
Proposed branch: lp:~l3on/ubuntu/precise/pino/fix-ftbfs
Merge into: lp:ubuntu/precise/pino
Diff against target: 96 lines (+38/-1)
6 files modified
.pc/applied-patches (+1/-0)
CMakeLists.txt (+2/-0)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/013_include-gthread.diff (+26/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~l3on/ubuntu/precise/pino/fix-ftbfs
Reviewer Review Type Date Requested Status
Andreas Moog (community) Disapprove
Ubuntu branches Pending
Review via email: mp+93730@code.launchpad.net

Description of the change

New patch to add explicit declaration for gthread libraries in CMakeLists.

This fixes FTBFS.

To post a comment you must log in.
Revision history for this message
Andreas Moog (ampelbein) wrote :

This got fixed in debian: http://packages.qa.debian.org/p/pino/news/20120219T152151Z.html, so I'll sync this package over (with credit to you, of course).

review: Disapprove
Revision history for this message
Leo Iannacone (l3on) wrote :

Ok, thanks Andreas!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2011-06-13 08:17:14 +0000
3+++ .pc/applied-patches 2012-02-19 14:26:19 +0000
4@@ -4,3 +4,4 @@
5 010_construct-only-properties.diff
6 011_get_style_property-fix.diff
7 012_libnotify-0.7.diff
8+013_include-gthread.diff
9
10=== modified file 'CMakeLists.txt'
11--- CMakeLists.txt 2011-06-13 08:17:14 +0000
12+++ CMakeLists.txt 2012-02-19 14:26:19 +0000
13@@ -59,6 +59,7 @@
14 pkg_check_modules(LIBUNIQUE REQUIRED "unique-1.0 >= 1.0")
15 pkg_check_modules(GTKSPELL REQUIRED "gtkspell-2.0 >= 2.0")
16 pkg_check_modules(LIBINDICATE "indicate >= 0.3")
17+pkg_check_modules(GTHREAD REQUIRED "gthread-2.0 >= 2.14.0")
18
19 set(pino_VALA_OPTIONS ${pino_VALA_OPTIONS} --thread)
20
21@@ -131,6 +132,7 @@
22 ${LIBUNIQUE_LIBRARIES}
23 ${GTKSPELL_LIBRARIES}
24 ${LIBINDICATE_LIBRARIES}
25+ ${GTHREAD_LIBRARIES}
26 )
27
28 include_directories(src/vapi/)
29
30=== modified file 'debian/changelog'
31--- debian/changelog 2011-07-31 08:08:02 +0000
32+++ debian/changelog 2012-02-19 14:26:19 +0000
33@@ -1,3 +1,9 @@
34+pino (0.2.11-9ubuntu1) precise; urgency=low
35+
36+ * Add support for gthread-2.0, fixes FTBFS (LP: #931691).
37+
38+ -- Leo Iannacone <l3on@ubuntu.com> Sun, 19 Feb 2012 12:12:53 +0100
39+
40 pino (0.2.11-9) unstable; urgency=low
41
42 * Upload to unstable
43
44=== modified file 'debian/control'
45--- debian/control 2011-07-31 08:08:02 +0000
46+++ debian/control 2012-02-19 14:26:19 +0000
47@@ -1,7 +1,8 @@
48 Source: pino
49 Section: net
50 Priority: optional
51-Maintainer: Julien Valroff <julien@debian.org>
52+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
53+XSBC-Original-Maintainer: Julien Valroff <julien@debian.org>
54 Standards-Version: 3.9.2
55 Build-Depends: debhelper (>= 8),
56 cmake (>= 2.6.0),
57
58=== added file 'debian/patches/013_include-gthread.diff'
59--- debian/patches/013_include-gthread.diff 1970-01-01 00:00:00 +0000
60+++ debian/patches/013_include-gthread.diff 2012-02-19 14:26:19 +0000
61@@ -0,0 +1,26 @@
62+Description: Add explicit declaration for gthread libraries. Fixes FTBFS.
63+Author: Leo Iannacone <l3on@ubuntu.com>
64+Bug-Ubuntu: https://bugs.launchpad.net/bugs/931691
65+
66+---
67+ CMakeLists.txt | 2 ++
68+ 1 file changed, 2 insertions(+)
69+
70+--- pino.orig/CMakeLists.txt
71++++ pino/CMakeLists.txt
72+@@ -59,6 +59,7 @@ pkg_check_modules(WEBKIT REQUIRED "webki
73+ pkg_check_modules(LIBUNIQUE REQUIRED "unique-1.0 >= 1.0")
74+ pkg_check_modules(GTKSPELL REQUIRED "gtkspell-2.0 >= 2.0")
75+ pkg_check_modules(LIBINDICATE "indicate >= 0.3")
76++pkg_check_modules(GTHREAD REQUIRED "gthread-2.0 >= 2.14.0")
77+
78+ set(pino_VALA_OPTIONS ${pino_VALA_OPTIONS} --thread)
79+
80+@@ -131,6 +132,7 @@ link_libraries(
81+ ${LIBUNIQUE_LIBRARIES}
82+ ${GTKSPELL_LIBRARIES}
83+ ${LIBINDICATE_LIBRARIES}
84++ ${GTHREAD_LIBRARIES}
85+ )
86+
87+ include_directories(src/vapi/)
88
89=== modified file 'debian/patches/series'
90--- debian/patches/series 2011-06-13 08:17:14 +0000
91+++ debian/patches/series 2012-02-19 14:26:19 +0000
92@@ -4,3 +4,4 @@
93 010_construct-only-properties.diff
94 011_get_style_property-fix.diff
95 012_libnotify-0.7.diff
96+013_include-gthread.diff

Subscribers

People subscribed via source and target branches

to all changes: