Code review comment for lp:~l3on/ubuntu-themes/gnome-shell-fixes

> I've given to this a first look and it seems very good...

Great!

> However, in order to match the unity defined shadows you should use this:
>
> .window-frame {
> border-radius: 10px 10px 0 0;
> box-shadow: 2px 10px 30px @window_shadow;
>
> /* this is used for the resize cursor area */
> margin: 10px;
> }
>
> .window-frame:backdrop {
> box-shadow: 2px 10px 25px @window_shadow_inactive;
> }

I tried, but I got an unexpected result. It seems blur effect used by GTK is not the same used by Unity. So, if you set the same values (@window_shadow*) you get different result.
It was true when I worked on windows, and I guess it's still so.

> Then, we've a problem... At least in unity: what in unity is a toolbar, using
> this theme becomes an headerbar and thus here it looks like we've two headers,
> which is something we can't go with.
> So, I'm not sure weather it's the case of fixing nautilus or adding some
> special theming for Nautilus.

Yes. You are right.
But the problem here is in Nautilus itself. The patch applied in the software (if I am not wrong) checks if current session is Unity, and if so, encloses the gtk-headerbar in a simple container.
The result is: you have a headerbar, supposed to be the "top-of-the-window", but displayed inside of it.
So, in this case, we have to review that patch (precisely: nautilus/debian/patches/ubuntu_show_titlebar.patch).

> I've noticed that using the Adwaita theme this
> problem doesn't happen here.
Only because in Adwaita headerbar and the other widgets use (more or less) the same colors.