Granite

Merge lp:~l-admin-3/granite/mode-button-fix into lp:~elementary-pantheon/granite/granite

  1. mode-button-fix
  2. Merge into granite
Proposed by Marcus Wichelmann
Status: Merged
Approved by: Cody Garver
Approved revision: 865
Merged at revision: 865
Proposed branch: lp:~l-admin-3/granite/mode-button-fix
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 11 lines (+1/-1)
1 file modified
lib/Widgets/ModeButton.vala (+1/-1)
To merge this branch: bzr merge lp:~l-admin-3/granite/mode-button-fix
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+268854@code.launchpad.net

Commit message

Fix "selected"-property of ModeButton.

Description of the change

This branch fixes a problem with the "selected"-property of the ModeButton. The notify-event for the property isn't fired, because the property get's not updated the right way.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

Seems right here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/ModeButton.vala'
2--- lib/Widgets/ModeButton.vala 2014-09-04 12:39:00 +0000
3+++ lib/Widgets/ModeButton.vala 2015-08-23 16:17:47 +0000
4@@ -121,7 +121,7 @@
5 item.add (w);
6
7 item.button_press_event.connect (() => {
8- set_active (item.index);
9+ selected = item.index;
10 return true;
11 });
12

Subscribers

People subscribed via source and target branches