Merge lp:~l-admin-3/eidete/dialog-margin-fix into lp:eidete

Proposed by Marcus Wichelmann
Status: Merged
Approved by: Tom Beckmann
Approved revision: 180
Merged at revision: 182
Proposed branch: lp:~l-admin-3/eidete/dialog-margin-fix
Merge into: lp:eidete
Diff against target: 41 lines (+5/-3)
2 files modified
src/Widgets/end_dialog.vala (+5/-2)
src/eidete.vala (+0/-1)
To merge this branch: bzr merge lp:~l-admin-3/eidete/dialog-margin-fix
Reviewer Review Type Date Requested Status
Tom Beckmann (community) Approve
Review via email: mp+245691@code.launchpad.net

Commit message

optimize margins, hide close button on end-dialog

Description of the change

I've decreased the content-margin of some dialogs and removed the close-button of the end-dialog.

To post a comment you must log in.
Revision history for this message
Tom Beckmann (tombeckmann) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/end_dialog.vala'
2--- src/Widgets/end_dialog.vala 2015-01-06 13:29:27 +0000
3+++ src/Widgets/end_dialog.vala 2015-01-06 20:02:49 +0000
4@@ -27,12 +27,14 @@
5 private File source;
6
7 public EndDialog (EideteApp app) {
8+ Object (use_header_bar: 1);
9+
10 this.app = app;
11-
12 this.window_position = Gtk.WindowPosition.CENTER_ON_PARENT;
13 }
14
15 private void build_ui () {
16+ (this.get_header_bar () as Gtk.HeaderBar).show_close_button = false;
17 this.get_header_bar ().get_style_context ().remove_class ("header-bar");
18 this.set_default_size (600, 600);
19 this.set_application (app);
20@@ -46,7 +48,8 @@
21 this.icon_name = "eidete";
22
23 grid = new Gtk.Grid ();
24- grid.margin = 12;
25+ grid.margin_start = 12;
26+ grid.margin_end = 12;
27
28 var content = (this.get_content_area () as Gtk.Box);
29
30
31=== modified file 'src/eidete.vala'
32--- src/eidete.vala 2015-01-06 13:29:27 +0000
33+++ src/eidete.vala 2015-01-06 20:02:49 +0000
34@@ -502,7 +502,6 @@
35
36 private void build_pause_ui () {
37 pause_grid = new Gtk.Grid ();
38- pause_grid.margin = 12;
39 // this.main_window.title = _("Recording paused");
40
41 var img_text_grid = new Gtk.Grid ();

Subscribers

People subscribed via source and target branches