Merge lp:~kzmd-deactivatedaccount/ubuntu/natty/compiz-plugins-main/popup-delay-fix-772177 into lp:ubuntu/natty/compiz-plugins-main

Proposed by kzmd on 2011-06-06
Status: Rejected
Rejected by: Didier Roche on 2011-06-07
Proposed branch: lp:~kzmd-deactivatedaccount/ubuntu/natty/compiz-plugins-main/popup-delay-fix-772177
Merge into: lp:ubuntu/natty/compiz-plugins-main
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
staticswitcher/staticswitcher.xml.in (+1/-1)
To merge this branch: bzr merge lp:~kzmd-deactivatedaccount/ubuntu/natty/compiz-plugins-main/popup-delay-fix-772177
Reviewer Review Type Date Requested Status
Didier Roche 2011-06-06 Disapprove on 2011-06-07
Review via email: mp+63536@code.launchpad.net

Description of the change

Fixes LP: #772177 by reducing the popup delay of the static switcher plugin from 0.2s to 0s.

To post a comment you must log in.
Didier Roche (didrocks) wrote :

Thanks for your patch and help to make ubuntu better.

However, I'll have to refuse that patch, we already tried to change the popup delay from 0.2s to 0.0s, but design came back because it's flashing when you just alt + tab quickly.

See the debian/changelog history:

compiz-plugins-main (0.9.4-0ubuntu4) natty; urgency=low

  * 03_default_options.patch:
    - revert the ubuntu change from 0s to 0.2s delay back to avoid flickering
    - show other window when doing alt-tab and ensure that the settings are
      according to LP: #736938

compiz-plugins-main (0.9.4-0ubuntu3) natty; urgency=low

  * 03_default_options.patch:
    - change default option from 0.2s delay to 0s for compiz staticswitcher plugin
    - don't get a close animation on gnome-screenshot (LP: #93234)
    - Change <Super> + e to <Super> + s for switch workspace (trigger expo mode)
      in the classic session as in unity (LP: #723273)
    - deactivate mipmapping in staticswitcher as it can make alt Tab very slow
      (some seconds) on some hardware (LP: #684843)

That's the reason why we reverted the change made in 0.9.4-0ubuntu3 as a design decision. That's why I will have to disapprove this change.

Do not hesitate to propose any patch on other issue to fix in compiz.
Thanks a lot!

review: Disapprove
MarcRandolph (mrand) wrote :

Didier Roche, please review the comments in LP: #772177 and reconsider your disapproval. Alt+tab is for quick window changes, and the delay basically eliminates the notion of it being "quick." Flickering is better than delay.

Didier Roche (didrocks) wrote :

@Marc: as you saw, it was already discussed and all the history is available on the changelog as I took the time to show there.

If you are really interested in that discussion, please ping the designers on irc, freenode network, #ayatana channel. That's where the decision was taken.

People wanting to change that value are still able to do so in ccsm though? We are just talking about defaults.

Unmerged revisions

9. By kzmd on 2011-06-06

* staticswitcher/staticswitcher.xml.in:
- Change popup delay from 0.2s to 0.0s (LP: #772177)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-19 11:40:24 +0000
3+++ debian/changelog 2011-06-06 09:45:55 +0000
4@@ -1,3 +1,10 @@
5+compiz-plugins-main (0.9.4+bzr20110406-0ubuntu3) natty; urgency=low
6+
7+ * staticswitcher/staticswitcher.xml.in:
8+ - Change popup delay from 0.2s to 0.0s (LP: #772177)
9+
10+ -- kzmd <kzmd@iinet.net.au> Mon, 06 Jun 2011 19:33:59 +1000
11+
12 compiz-plugins-main (0.9.4+bzr20110406-0ubuntu2) natty; urgency=low
13
14 * debian/patches/00_bzr_fix_centered_expo.patch:
15
16=== modified file 'staticswitcher/staticswitcher.xml.in'
17--- staticswitcher/staticswitcher.xml.in 2011-04-07 14:21:07 +0000
18+++ staticswitcher/staticswitcher.xml.in 2011-06-06 09:45:55 +0000
19@@ -143,7 +143,7 @@
20 <option name="popup_delay" type="float">
21 <_short>Popup Window Delay</_short>
22 <_long>Time (in s) the popup window should be delayed before appearing</_long>
23- <default>0.2</default>
24+ <default>0.0</default>
25 <min>0.0</min>
26 <max>2.0</max>
27 <precision>0.05</precision>

Subscribers

People subscribed via source and target branches

to all changes: