Merge lp:~kzapalowicz/ubuntu-system-settings/ubuntu-system-settings-carfix2 into lp:ubuntu-system-settings

[Konrad Zapałowicz]

Make device always valid.

The current implementation set the device status to valid only when the
type of the device has been known. This has been provided by reading
Class of Device or Appearance properties which in some cases such as
inbound pairing with yet unknown device has to be queried. Now, some
of the remote devices such as cars do not make themselves discoverable
when initiate pairing which make us unable to query it's type. As a
result the device has been permanently invalid and the pairing failed.

This change makes sure that the device is always valid.

Make device always valid

The current implementation set the device status to valid only when the
type of the device has been known. This has been provided by reading
Class of Device or Appearance properties which in some cases such as
inbound pairing with yet unknown device has to be queried. Now, some
of the remote devices such as cars do not make themselves discoverable
when initiate pairing which make us unable to query it's type. As a
result the device has been permanently invalid and the pairing failed.

This change makes sure that the device is always valid.

[Matteo Croce (teknoraver)]

review: Approve

[Ken VanDine (ken-vandine)]

Please drop the changelog entry, citrain will fill that in for you.

review: Needs Fixing

[Simon Fels (morphis)]

Please explain in the commit message why you do this. Simply copy over the description into the commit message. Otherwise LGTM

review: Needs Fixing

[lp:~kzapalowicz/ubuntu-system-settings/ubuntu-system-settings-carfix2]

1682. By Konrad Zapałowicz on 2016-08-03

Revert changelog modification

[Ken VanDine (ken-vandine)]

Thanks, looks good

review: Approve

[lp:~kzapalowicz/ubuntu-system-settings/ubuntu-system-settings-carfix2]

1683. By Konrad Zapałowicz on 2016-08-11

merge with upstream

1684. By Konrad Zapałowicz on 2016-08-11

merge with upstream

=== modified file 'plugins/bluetooth/device.h'
--- plugins/bluetooth/device.h	2016-07-28 10:08:54 +0000
+++ plugins/bluetooth/device.h	2016-08-11 12:33:38 +0000
@@ -142,7 +142,7 @@
     Device() {}
     Device(const QString &path, QDBusConnection &bus);
     ~Device() {}
-    bool isValid() const { return getType() != Type::Other; }
+    bool isValid() const { return true; }
     void pair();
     Q_INVOKABLE void cancelPairing();
     void connect();