snappy-hwe-snaps

Merge ~kzapalowicz/snappy-hwe-snaps/+git/wireless-tools:feature/rfkill into ~snappy-hwe-team/snappy-hwe-snaps/+git/wireless-tools:master

  1. Git
  2. lp:~kzapalowicz/snappy-hwe-snaps/+git/wireless-tools
  3. feature/rfkill
  4. Merge into master
Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: 90694e1b8a3c0b571cfca94249e22563ca183e8c
Merged at revision: 61c917611fc439bf3974f49ce9c3d332674f5d61
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/wireless-tools:feature/rfkill
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/wireless-tools:master
Diff against target: 39 lines (+13/-1)
1 file modified
snapcraft.yaml (+13/-1)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Jim Hodapp (community) code Approve
Review via email: mp+309955@code.launchpad.net

Commit message

Add rfkill tool.

Description of the change

Add rfkill tool.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:8f51e510cb4bcdabe1f4e5f321a810863806e1ad
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/253/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/155/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/253/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:c745877fa28f1c43d9f59b9d1e3862e3f9899690
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/254/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/156/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/254/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) :
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:0ac8f16be5ef0bfd25492a7b6795c800b5e06346
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/255/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/157/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/255/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index ea5dcb6..156e881 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -5,10 +5,12 @@ description: |
6 This snap contains the Wireless tools, used to manipulate
7 the Linux Wireless Extensions. The Wireless Extension is an interface
8 allowing you to set Wireless LAN specific parameters and get the
9- specific stats.
10+ specific stats. Also the Wireless tools include the rfkill tool to
11+ query and manage the state of the rfkill switches.
12 Please find the source of this snap at the following location:
13 https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/wireless-tools
14 confinement: strict
15+grade: stable
16
17 apps:
18 iw:
19@@ -29,6 +31,9 @@ apps:
20 iwevent:
21 command: sbin/iwevent
22 plugs: [network-control, network, network-bind]
23+ rfkill:
24+ command: usr/sbin/rfkill
25+ plugs: [network-control]
26
27 parts:
28 wireless-tools:
29@@ -40,3 +45,10 @@ parts:
30 - sbin/
31 - usr/share/doc/wireless-tools/
32 - usr/share/doc/iw/
33+ rfkill:
34+ plugin: nil
35+ stage-packages:
36+ - rfkill
37+ snap:
38+ - usr/share/doc/rfkill/copyright
39+ - usr/sbin/rfkill

Subscribers

People subscribed via source and target branches