Merge ~kzapalowicz/snappy-hwe-snaps/+git/udisks2:fix/build-issue into ~snappy-hwe-team/snappy-hwe-snaps/+git/udisks2:ciborium/0.2.12

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: ea36defdb78cf6f07f8422993717453c17b167df
Merged at revision: 7f3747000337772a5db1c77a396f83cd7ddcfad0
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/udisks2:fix/build-issue
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/udisks2:ciborium/0.2.12
Diff against target: 47 lines (+6/-2)
2 files modified
cmd/ciborium-ui/main.go (+1/-2)
run-tests.sh (+5/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Simon Fels Approve
Review via email: mp+317944@code.launchpad.net

Commit message

fix build issue in -ui related to recent udisks2 changes

The NewStorageWatcher has now only one argument and is allowing all
file system ssupported by the kernel to be mounted.

This commit changes the ciborium-ui accordingly

Description of the change

fix build issue in -ui related to recent udisks2 changes

The NewStorageWatcher has now only one argument and is allowing all
file system ssupported by the kernel to be mounted.

This commit changes the ciborium-ui accordingly

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/cmd/ciborium-ui/main.go b/cmd/ciborium-ui/main.go
2index 426d5a8..3b5e2b4 100644
3--- a/cmd/ciborium-ui/main.go
4+++ b/cmd/ciborium-ui/main.go
5@@ -50,7 +50,6 @@ type DriveList struct {
6 }
7
8 var mainQmlPath = filepath.Join("ciborium", "qml", "main.qml")
9-var supportedFS []string = []string{"vfat"}
10
11 func init() {
12 os.Setenv("APP_ID", "ciborium")
13@@ -110,7 +109,7 @@ func newDriveControl() (*driveControl, error) {
14 if err != nil {
15 return nil, err
16 }
17- udisks := udisks2.NewStorageWatcher(systemBus, supportedFS...)
18+ udisks := udisks2.NewStorageWatcher(systemBus)
19
20 return &driveControl{udisks: udisks}, nil
21 }
22diff --git a/run-tests.sh b/run-tests.sh
23index 9645219..968554e 100755
24--- a/run-tests.sh
25+++ b/run-tests.sh
26@@ -9,6 +9,7 @@ fi
27 $SUDO apt update
28 $SUDO apt install -y --force-yes \
29 golang-go \
30+ libqt5opengl5-dev pkg-config qtbase5-private-dev qtdeclarative5-private-dev \
31 bzr
32
33 export GOPATH=`mktemp -d`
34@@ -17,9 +18,13 @@ mkdir -p $GOPATH/src/launchpad.net
35 ln -sf $PWD $GOPATH/src/launchpad.net/ciborium
36
37 go get -v launchpad.net/ciborium/cmd/ciborium
38+go get -v launchpad.net/ciborium/cmd/ciborium-ui
39 go get -v -t launchpad.net/ciborium/cmd/ciborium
40+go get -v -t launchpad.net/ciborium/cmd/ciborium-ui
41
42 go build -v launchpad.net/ciborium/cmd/ciborium
43+go build -v launchpad.net/ciborium/cmd/ciborium-ui
44
45 go test -v launchpad.net/ciborium/cmd/ciborium
46+go test -v launchpad.net/ciborium/cmd/ciborium-ui
47 go test -v launchpad.net/ciborium/udisks2

Subscribers

People subscribed via source and target branches