snappy-hwe-snaps

Merge ~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs:fix/do-not-quote-passwords into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

  1. Git
  2. lp:~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs
  3. fix/do-not-quote-passwords
  4. Merge into master
Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 28f5efd5f22688f88e455375dbcd84f40eb0f850
Merged at revision: a257b5189e0024e5d84559ec5fc45957aa9d8436
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs:fix/do-not-quote-passwords
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 13 lines (+1/-1)
1 file modified
jobs/infrastructure/credentials-2-launchpad-plugin.sh (+1/-1)
Reviewer Review Type Date Requested Status
Konrad Zapałowicz (community) continuous-integration Approve
Alfonso Sanchez-Beato Approve
Review via email: mp+330972@code.launchpad.net

Description of the change

do not quote the deployment password

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Revision history for this message
Konrad Zapałowicz (kzapalowicz) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/infrastructure/credentials-2-launchpad-plugin.sh b/jobs/infrastructure/credentials-2-launchpad-plugin.sh
2index 59dd324..f1358b2 100644
3--- a/jobs/infrastructure/credentials-2-launchpad-plugin.sh
4+++ b/jobs/infrastructure/credentials-2-launchpad-plugin.sh
5@@ -49,7 +49,7 @@ jenkins_password: "${{jenkins_api_token}}"
6
7 #These credentials are only used for actually deploying jenkins jobs
8 jenkins_deploy_user: "{deploy_bot_username}"
9-jenkins_deploy_password: "${{jenkins_deploy_api_token}}"
10+jenkins_deploy_password: ${{jenkins_deploy_api_token}}
11
12 #Actual URL of your jenkins (e.g. the jenkins backend URL)
13 jenkins_url: "{backend_url}"

Subscribers

People subscribed via source and target branches