Merge ~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs:feature/use-http-proxy-for-pip into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: 6df94f812d40c313e198ad8426feaaf320db4c95
Merged at revision: e3e7361e8ad6f174d8d4e689e19cb97a3058243d
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs:feature/use-http-proxy-for-pip
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 13 lines (+2/-0)
1 file modified
jobs/infrastructure/prepare-0-install.sh (+2/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Simon Fels Approve
Jim Hodapp (community) Approve
Review via email: mp+328078@code.launchpad.net

Description of the change

jobs/infrastructure: make pip use http_proxy

pip needs to use {http,https}_proxy in order to work. Details in
RT ticket: https://rt.admin.canonical.com/Ticket/Display.html?id=104473

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

You've verified this does indeed solve the issue on our Jenkins deployment?

Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

@Jim, this is what the IT has suggested so theoretically yes, practically we will see.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Fair enough.

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@kzapalowicz as a suggestion, why don't you test this simply by creating an auxiliar job in one of our jenkins instances and pasting around some code that uses pip? Just to prove this is what we actually need and to avoid more PRs in case this needs corrections.

Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/infrastructure/prepare-0-install.sh b/jobs/infrastructure/prepare-0-install.sh
2index f2f3047..2c081e7 100644
3--- a/jobs/infrastructure/prepare-0-install.sh
4+++ b/jobs/infrastructure/prepare-0-install.sh
5@@ -52,6 +52,8 @@ sudo apt-get install --yes \
6 postfix \
7 {install_packages}
8
9+export http_proxy="http://squid.internal:3128/"
10+export https_proxy="http://squid.internal:3128/"
11 # Install additional sofware from the python package database
12 sudo pip install --upgrade pip
13 sudo pip install jenkins-job-builder

Subscribers

People subscribed via source and target branches