snappy-hwe-snaps

Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/validate-pxu-files into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests
  3. fix/validate-pxu-files
  4. Merge into master
Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Jim Hodapp
Approved revision: 48d78977a76f6230de2bbafafcfb89a3f613685b
Merged at revision: 56a23a4d9de105e77fd0ddc81aba742aab0878e9
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/validate-pxu-files
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 15 lines (+0/-4)
1 file modified
media-hub/units/media-hub-snap.pxu (+0/-4)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+322584@code.launchpad.net

Description of the change

media-hub: fix category id field clash for test units

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:65c9e4acb8cab661a518535dbb32a193b123defa
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1460/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1059/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1368/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/683/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1460/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:65c9e4acb8cab661a518535dbb32a193b123defa
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1461/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1060
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1369/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1597
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/684/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1461/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

This isn't the right approach, take a look at the network-manager one. You only need to define the top level id in one .pxu file for generic media-hub, and then the snap-specific pxu file wouldn't have the definition at all.

https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests/tree/network-manager/units/network-manager.pxu

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:48d78977a76f6230de2bbafafcfb89a3f613685b
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1462/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1131/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1370/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/752/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1462/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:48d78977a76f6230de2bbafafcfb89a3f613685b
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1464/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1133/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1372/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/754

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1464/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:48d78977a76f6230de2bbafafcfb89a3f613685b
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1465/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1134
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1373/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1623
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/755/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1465/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/media-hub/units/media-hub-snap.pxu b/media-hub/units/media-hub-snap.pxu
2index 1b2734f..24ad2bc 100644
3--- a/media-hub/units/media-hub-snap.pxu
4+++ b/media-hub/units/media-hub-snap.pxu
5@@ -4,10 +4,6 @@
6 # Written by:
7 # Alfonso Sánchez-Beato <alfonso.sanchez-beato@canonical.com>
8
9-unit: category
10-id: media_hub
11-_name: media-hub
12-
13 id: media_hub/snap_classic/play_wav
14 category_id: media_hub
15 plugin: manual

Subscribers

People subscribed via source and target branches