snappy-hwe-snaps

Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/extend-bluez-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests
  3. feature/extend-bluez-tests
  4. Merge into master
Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Jim Hodapp
Approved revision: fbd8832bdffdee53787df153c9408e7824e9c8e0
Merged at revision: 762578bf33d09260d111ce802deca3ee77c1266e
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/extend-bluez-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 45 lines (+37/-0)
1 file modified
bluez/units/setup.pxu (+37/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Jim Hodapp (community) Approve
Matteo Croce (community) Approve
Review via email: mp+319815@code.launchpad.net

Description of the change

Add tests to verify btmon and hcidump commands function.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:58a772eebf44808899938375387e55ee0106c92c
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1302/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/471
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1210/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1116
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/133/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1302/rebuild

review: Approve (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few changes needed.

review: Needs Fixing
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:fbd8832bdffdee53787df153c9408e7824e9c8e0
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1307/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/476/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1215/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/138/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1307/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bluez/units/setup.pxu b/bluez/units/setup.pxu
2index 684f53c..80d9413 100644
3--- a/bluez/units/setup.pxu
4+++ b/bluez/units/setup.pxu
5@@ -84,3 +84,40 @@ _verification:
6 Connection successful
7 [CHG] Device 04:52:C7:0D:0C:03 ServicesResolved: yes
8
9+id: bluez/snap/ensure_btmon_can_be started
10+category_id: bluez
11+plugin: manual
12+depends: bluez/setup/ensure_interface_connection_setup
13+_summary: btmon tools function
14+_purpose:
15+ Check that the btmon tool shipped as a part of the bluez snap can be used.
16+_steps:
17+ 1. Start the btmon command
18+ .
19+ $ sudo btmon
20+ .
21+_verification:
22+ You should see outout similar to the following:
23+ .
24+ $ sudo btmon
25+ Bluetooth monitor ver 5.37
26+ = New Index: 00:1A:7D:DA:71:08 (BR/EDR,USB,hci0) [hci0] 0.626494
27+
28+id: bluez/snap/ensure_hcidump_can_be started
29+category_id: bluez
30+plugin: manual
31+depends: bluez/setup/ensure_interface_connection_setup
32+_summary: btmon tools works
33+_purpose:
34+ Check that the hcidump tool shipped as a part of the bluez snap can be used.
35+_steps:
36+ 1. Start the hcidump command
37+ .
38+ $ sudo hcidump
39+ .
40+_verification:
41+ You should see outout similar to the following:
42+ .
43+ $ sudo hcidump
44+ HCI sniffer - Bluetooth packet analyzer ver 5.37
45+ device: hci0 snap_len: 1500 filter: 0xffffffff

Subscribers

People subscribed via source and target branches