Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/fix-ambiguous-test-cases into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: eaacee0e562f3dd58cccaa5dd7c5d19b047bbcc9
Merged at revision: f988a9d86cd6ede46e81c3e04963426d901b2764
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/fix-ambiguous-test-cases
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 39 lines (+7/-3)
2 files modified
tpm/units/tpm.pxu (+3/-3)
udisks2/units/udisks2.pxu (+4/-0)
Reviewer Review Type Date Requested Status
Simon Fels continuous-integration Approve
System Enablement Bot continuous-integration Needs Fixing
Review via email: mp+317756@code.launchpad.net

Description of the change

fix tpm and udisks2 test cases to be more
user-friendly

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Approving for CI

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tpm/units/tpm.pxu b/tpm/units/tpm.pxu
2index cbbf256..b00bd89 100644
3--- a/tpm/units/tpm.pxu
4+++ b/tpm/units/tpm.pxu
5@@ -15,9 +15,9 @@ plugin: manual
6 _steps:
7 1. Connect required tpm1.2 slots/plugs
8 .
9- $ sudo snap connect tpm:network ubuntu-core:network
10- $ sudo snap connect tpm:network-bind ubuntu-core:network-bind
11- $ sudo snap connect tpm:tpm ubuntu-core:tpm
12+ $ sudo snap connect tpm:network :network
13+ $ sudo snap connect tpm:network-bind :network-bind
14+ $ sudo snap connect tpm:tpm :tpm
15 .
16 _verification:
17 Verify that you see the following when running snap interfaces:
18diff --git a/udisks2/units/udisks2.pxu b/udisks2/units/udisks2.pxu
19index d1081d5..a889427 100644
20--- a/udisks2/units/udisks2.pxu
21+++ b/udisks2/units/udisks2.pxu
22@@ -21,6 +21,7 @@ _verification:
23 Slot Plug
24 :mount-observe udisks2
25 udisks2:service udisks2:client
26+ - udisks2:hardware-observe
27
28 id: udisks2/client/can_communicate_with_udisksd
29 category_id: udisks2
30@@ -105,6 +106,9 @@ _steps:
31 .
32 Make sure the contents of that directory match what you expect to see on
33 the drive.
34+ .
35+ Leave the root shell
36+ $ exit
37 5. Unmount the filesystem:
38 .
39 $ sudo udisks2.udisksctl unmount -b /dev/<device>1

Subscribers

People subscribed via source and target branches