Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/plainbox-pulseaudio into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: 37144602bddcb6d3db5ed826144c3cd152c47c33
Merged at revision: 8ba3e66b06837dd271aa1da970c8398f9c2d49f1
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/plainbox-pulseaudio
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 52 lines (+29/-0)
3 files modified
bin/run-pulseaudio-tests (+5/-0)
snapcraft.yaml (+2/-0)
tests/units/pulseaudio.pxu (+22/-0)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Needs Fixing
Jim Hodapp (community) code Approve
Review via email: mp+311625@code.launchpad.net

Commit message

Add Plainbox tests for PulseAudio

This commit adds Plainbox tests for PulseAudio. The test set,
at this moment, contains just one test to verify that the
interface is auto-connected.

Description of the change

Add Plainbox tests for PulseAudio

This commit adds Plainbox tests for PulseAudio. The test set,
at this moment, contains just one test to verify that the
interface is auto-connected.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/run-pulseaudio-tests b/bin/run-pulseaudio-tests
2new file mode 100755
3index 0000000..40036f5
4--- /dev/null
5+++ b/bin/run-pulseaudio-tests
6@@ -0,0 +1,5 @@
7+#!/bin/sh
8+export PATH="$PATH:$SNAP/usr/sbin"
9+exec python3 $(which plainbox) \
10+ run -i '2016.com.canonical.system-enablement::pulseaudio.*' \
11+ "$@"
12diff --git a/snapcraft.yaml b/snapcraft.yaml
13index 42b0068..49fb689 100644
14--- a/snapcraft.yaml
15+++ b/snapcraft.yaml
16@@ -27,6 +27,8 @@ apps:
17 command: bin/run-wifi-ap-tests
18 wireless-tools:
19 command: bin/run-wireless-tools-tests
20+ pulseaudio:
21+ command: bin/run-pusleaudio-tests
22
23 parts:
24 common:
25diff --git a/tests/units/pulseaudio.pxu b/tests/units/pulseaudio.pxu
26new file mode 100644
27index 0000000..28d5deb
28--- /dev/null
29+++ b/tests/units/pulseaudio.pxu
30@@ -0,0 +1,22 @@
31+# Copyright 2016 Canonical Ltd.
32+# All rights reserved.
33+#
34+# Written by:
35+# Konrad Zapalowicz <konrad.zapalowicz@canonical.com>
36+
37+unit: category
38+id: pulseaudio
39+_name: PulseAudio
40+
41+id: pulseaudio/setup/ensure_interface_connection_setup
42+category_id: pulseaudio
43+_description: Ensure that the pulseaudio interface is auto-connected
44+plugin: manual
45+_steps:
46+ 1. List the interfaces
47+ .
48+ $ snap interfaces
49+ .
50+_verification:
51+ Verify that you see the following:
52+ pulseaudio:service pulseaudio:client

Subscribers

People subscribed via source and target branches