Merge ~kzapalowicz/snappy-hwe-snaps/+git/build-scripts:fix/snap-version-issue into ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master
Proposed by
Konrad Zapałowicz
Status: | Superseded |
---|---|
Proposed branch: | ~kzapalowicz/snappy-hwe-snaps/+git/build-scripts:fix/snap-version-issue |
Merge into: | ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
System Enablement Bot | continuous-integration | Approve | |
Review via email: mp+319979@code.launchpad.net |
This proposal has been superseded by a proposal from 2017-03-15.
Description of the change
Fix empty snap name for files with comments on top.
Some snapcraft.yaml files have a header that contains
commented-out version information. Due to that the name is not
within first five lines.
This commit makes the snap name rule skip the lines that start
with the comment '#'
To post a comment you must log in.
Unmerged commits
- e82f413... by =?utf-8?q?Konrad_Zapa=C5=82owicz?= <email address hidden>
PASSED: Continuous integration, rev:e82f413650d 6a89f56b79bbfea fbc5275419e84b /jenkins. canonical. com/system- enablement/ job/generic- build-snap/ 1319/ /jenkins. canonical. com/system- enablement/ job/generic- build-snap- worker/ 498 /jenkins. canonical. com/system- enablement/ job/generic- update- snap-mp/ 1227/console /jenkins. canonical. com/system- enablement/ job/generic- test-snap/ 1139
https:/
Executed test runs:
SUCCESS: https:/
None: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/system- enablement/ job/generic- build-snap/ 1319/rebuild
https:/