Merge lp:~kyrofa/unity-scopes-api/1452423_fix-tutorial-typos into lp:unity-scopes-api

Proposed by Kyle Fazzari
Status: Superseded
Proposed branch: lp:~kyrofa/unity-scopes-api/1452423_fix-tutorial-typos
Merge into: lp:unity-scopes-api
Diff against target: 30 lines (+3/-3)
1 file modified
doc/tutorial.dox (+3/-3)
To merge this branch: bzr merge lp:~kyrofa/unity-scopes-api/1452423_fix-tutorial-typos
Reviewer Review Type Date Requested Status
Michi Henning (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+258427@code.launchpad.net

This proposal has been superseded by a proposal from 2015-05-07.

Commit message

Fix a couple typos in the tutorial.

Description of the change

This simply fixes a couple of typos found in the tutorial.

To test:

1) Look at old documentation, and notice the following sentence: "Prior to sending any queries, the scopes run time calls run() if your stop() method completed successfully (did not throw an exception)."

2) Regenerate documentation based on this MP:

$ cmake /path/to/src
$ make doc

3) Open up doc/index.html and notice that the sentence is now: "Prior to sending any queries, the scopes run time calls run() if your start() method completed successfully (did not throw an exception)." A few other smaller typos were also corrected.

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

Great, thanks for that!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

I just realized that you targeted this at trunk, but it really should be devel. Nothing wrong with the MR as such, just the wrong target branch. Can you re-submit for the correct branch please?

review: Needs Fixing

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/tutorial.dox'
2--- doc/tutorial.dox 2015-04-22 13:19:12 +0000
3+++ doc/tutorial.dox 2015-05-06 19:36:03 +0000
4@@ -181,7 +181,7 @@
5 The scopes run time calls \link unity::scopes::ScopeBase::stop() stop()\endlink to inform your scope
6 that it should shut down. You can use this method to perform any one-time clean-up.
7
8-Prior to sending any queries, the scopes run time calls \link unity::scopes::ScopeBase::run() run()\endlink if your `stop()` method
9+Prior to sending any queries, the scopes run time calls \link unity::scopes::ScopeBase::run() run()\endlink if your `start()` method
10 completed successfully (did not throw an exception). The `run()` method
11 is called by a separate thread that you can use for your own purposes, for example, to run an event loop.
12 The scopes run time has no further interest in this thread, but you must ensure that, if you do not return
13@@ -191,7 +191,7 @@
14
15 \paragraph handlingsearch Handling search
16
17-The unity::scopes::ScopeBase::search() method is called once for each query. Its purpose is to instantiante
18+The unity::scopes::ScopeBase::search() method is called once for each query. Its purpose is to instantiate
19 and return a new C++ instance that encapsulates the query, that is, `search()` is a factory method.
20 (Do not start execution of the query as part of `search()`; the query object has a separate method for this.)
21
22@@ -295,7 +295,7 @@
23 `run()` to execute the query.
24
25 The \link unity::scopes::SearchReplyProxy SearchReplyProxy\endlink that is passed to `run()` is an invocation
26-handle that allows you push results for the query back towards the client. (`SearchReplyProxy` is a `shared_ptr`
27+handle that allows you to push results for the query back towards the client. (`SearchReplyProxy` is a `shared_ptr`
28 to a \link unity::scopes::SearchReply SearchReply\endlink object.)
29
30 Two important methods of `SerchReply` are \link unity::scopes::SearchReply::register_category register_category()\endlink

Subscribers

People subscribed via source and target branches

to all changes: